-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow storing 2024 geometry in GEMGeometryParsFromDD #44429
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44429/39503
|
A new Pull Request was created by @watson-ij for master. It involves the following packages:
@makortel, @bsunanda, @srimanob, @subirsarkar, @cmsbuild, @mdhildreth, @Dr15Jones, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8aae7/38191/summary.html Comparison SummarySummary:
|
+1 |
@watson-ij |
Hi @srimanob . Yes, the update should not affect the 2021 geometry dumping either. I just checked, and when using GeometryExtended2021_cff the current code will dump out a geometry with the GE1/1 and the one GE2/1 demonstrator, as it should, and GeometryExtended2024_cff gives the 3 GE2/1 chambers. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The GEMGeometryParsFromDDD has a check for the demonstrator which doesn't work for the 2024 geometry. This PR allows the geometry to be dumped properly in order to make a tag.
PR validation:
Dumped the 2024 geometry (with modified version of [1] to load 2024) and checked that it ran over some 2024 data to read out the new GEM chambers (using also the 2024 alignments and channel map). Since it only affects writing the geometry, there should be no visible changes with this PR.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Before submitting your pull requests, make sure you followed this checklist: