[CPP20][L1,UPGRADE] Remove deprecated enum arithmetic

[iarspider]

PR description:

Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.

PR validation:

Bot tests.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44489/39578

• This PR adds an extra 64KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/src/JetId.cc modified in PR(s): Update of the Phase-2 GMT Emulator #44319

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• L1Trigger/CSCTrackFinder (l1)
• L1Trigger/GlobalCaloTrigger (l1)
• L1Trigger/HardwareValidation (l1)
• L1Trigger/L1ExtraFromDigis (l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
• L1Trigger/RPCTrigger (l1)
• L1Trigger/TrackFindingTracklet (l1)
• L1Trigger/TrackTrigger (upgrade, l1)
• L1Trigger/VertexFinder (l1)

@subirsarkar, @srimanob, @epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @JanFSchulte, @skinnari, @erikbutz, @sviret this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38290/summary.html
COMMIT: 6c56761
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44489/38290/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @vlimant adding JME nano in autoNano #44087
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @fwyzard Update the HLT alpaka customisation #44439
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38290/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38290/git-merge-result

Build

I found compilation warning when building: See details on the summary page.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44489/39597

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/src/JetId.cc modified in PR(s): Update of the Phase-2 GMT Emulator #44319

[cmsbuild]

Pull request #44489 was updated. @srimanob, @epalencia, @subirsarkar, @aloeliger can you please check and sign again.

[makortel]

Arithmetic with enums is a sign that maybe the enum should really be replaced with constexpr constants. I think this alternative should be explored first before going the static_cast route.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/summary.html
COMMIT: 740499d
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44489/38309/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @vlimant adding JME nano in autoNano #44087
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @fwyzard Update the HLT alpaka customisation #44439
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/git-merge-result

Comparison Summary

Summary:

• You potentially added 2253 lines to the logs
• Reco comparison results: 136 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 1857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3295492
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[iarspider]

hold As suggested, I will replace enums with constexpr ints.

…

On Wed, Mar 20, 2024, 22:20 cmsbuild ***@***.***> wrote: +1 *Summary*: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/summary.html *COMMIT*: 740499d <740499d> *CMSSW*: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12 *User test area*: For local testing, you can use /cvmfs/ cms-ci.cern.ch/week1/cms-sw/cmssw/44489/38309/install.sh to create a dev area with all the needed externals and cmssw changes. The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: - @makortel <https://github.com/makortel> #44445 <#44445> - @germanfgv <https://github.com/germanfgv> #44430 <#44430> - @valsdav <https://github.com/valsdav> #44455 <#44455> - @fwyzard <https://github.com/fwyzard> #44441 <#44441> - @Dr15Jones <https://github.com/Dr15Jones> #44462 <#44462> - @smuzaffar <https://github.com/smuzaffar> #44426 <#44426> - @iarspider <https://github.com/iarspider> #44448 <#44448> - @aehart <https://github.com/aehart> #44427 <#44427> - @valsdav <https://github.com/valsdav> #44376 <#44376> - @vlimant <https://github.com/vlimant> #44087 <#44087> - @swagata87 <https://github.com/swagata87> #44423 <#44423> - @stahlleiton <https://github.com/stahlleiton> #44422 <#44422> - @fwyzard <https://github.com/fwyzard> #44439 <#44439> - @mmusich <https://github.com/mmusich> #44434 <#44434> - @watson-ij <https://github.com/watson-ij> #44429 <#44429> You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46220a/38309/git-merge-result Comparison Summary *Summary*: - You potentially added 2253 lines <https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-03-18-1100+46220a/61845/validateJR/logRootQA-events.log> to the logs - Reco comparison results: 136 differences found in the comparisons <https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-03-18-1100+46220a/61845/validateJR.html> - DQMHistoTests: Total files compared: 48 - DQMHistoTests: Total histograms compared: 3297369 <3297369> - DQMHistoTests: Total failures: 1857 <https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-03-18-1100+46220a/61845/validateJR.html> - DQMHistoTests: Total nulls: 0 - DQMHistoTests: Total successes: 3295492 - DQMHistoTests: Total skipped: 20 - DQMHistoTests: Total Missing objects: 0 - DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared) - Checked 202 log files, 165 edm output root files, 48 DQM output files - TriggerResults <https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-03-18-1100+46220a/61845/triggerResults>: found differences in 5 / 46 workflows — Reply to this email directly, view it on GitHub <#44489 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE3NOUEFCDKQRDUPCQ2PQTYZH4TDAVCNFSM6AAAAABE7I2GX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJQGY3DAMBSHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cmsbuild]

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all