[CPP20][GEOMETRY] Remove deprecated enum arithmetic

[iarspider]

PR description:

Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.

PR validation:

Bot tests.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44488/39577

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Geometry/CaloEventSetup (geometry)
• Geometry/CaloTopology (geometry)
• Geometry/EcalTestBeam (geometry)
• Geometry/ForwardGeometry (geometry)

@mdhildreth, @bsunanda, @Dr15Jones, @makortel, @civanch can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @wang0jin, @bsunanda, @rchatter, @thomreis, @argiro this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

The arithmetic on enum is a sign that maybe the value would be better expressed as constexpr constant. I think it would be good to explore that approach before going with static_cast.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c564/38288/summary.html
COMMIT: f02a4a8
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44488/38288/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @vlimant adding JME nano in autoNano #44087
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @fwyzard Update the HLT alpaka customisation #44439
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c564/38288/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c564/38288/git-merge-result

Comparison Summary

Summary:

• You potentially added 2239 lines to the logs
• Reco comparison results: 120 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 502
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3296847
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[antoniovilela]

The arithmetic on enum is a sign that maybe the value would be better expressed as constexpr constant. I think it would be good to explore that approach before going with static_cast.

@iarspider

I already merged two similar PRs. In case you change the implementation, please go back to those two as well.

[iarspider]

hold Will redo using constexprs

…

On Wed, Mar 20, 2024, 23:33 antoniovilela ***@***.***> wrote: The arithmetic on enum is a sign that maybe the value would be better expressed as constexpr constant. I think it would be good to explore that approach before going with static_cast. @iarspider <https://github.com/iarspider> I already merged two similar PRs. In case you change the implementation, please go back to those two as well. — Reply to this email directly, view it on GitHub <#44488 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE3NOR53LGF725UMGLI24TYZIFEDAVCNFSM6AAAAABE7IVZ5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJQG43DOMBVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cmsbuild]

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all