Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPP20][DQM] Remove deprecated enum arithmetic #44487

Closed
wants to merge 1 commit into from
Closed

[CPP20][DQM] Remove deprecated enum arithmetic #44487

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

PR description:

Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.

PR validation:

Bot tests.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 20, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024 •
edited
Loading

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CPP20_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44487/39576

  • This PR adds an extra 96KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DQM/CTPPS (dqm)
  • DQM/EcalCommon (dqm)
  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)
  • DQM/SiPixelHeterogeneous (dqm)
  • DQMOffline/Alignment (dqm)
  • Validation/MuonCSCDigis (dqm)
  • Validation/RecoEgamma (dqm)

@rvenditti, @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks.
@fabferro, @idebruyn, @fioriNTU, @JanFSchulte, @wang0jin, @missirol, @rociovilar, @thomreis, @mmusich, @jandrea, @threus, @grzanka, @argiro, @ReyerBand, @rchatter this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-362d8b/38289/summary.html
COMMIT: 48668c3
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44487/38289/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-362d8b/38289/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-362d8b/38289/git-merge-result

Comparison Summary

Summary:

@iarspider iarspider mentioned this pull request Mar 22, 2024
Merged
@iarspider iarspider closed this Mar 25, 2024
@iarspider iarspider deleted the cpp20-no-enum-arithmetics-dqm branch March 25, 2024 08:40
@iarspider iarspider restored the cpp20-no-enum-arithmetics-dqm branch March 25, 2024 08:40
@iarspider iarspider deleted the cpp20-no-enum-arithmetics-dqm branch March 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-pending orp-pending pending-signatures tests-approved trk
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
2 participants
@iarspider @cmsbuild