Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slimmedMETsNoHF and possible cleanup #44335

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

wajidalikhan
Copy link
Contributor

@wajidalikhan wajidalikhan commented Mar 7, 2024

PR description:

  • slimmedMETsNoHF collection in MiniAOD is just MET without considering PF candidates in the HF region
  • Its impact on the MiniAOD size is negligible
  • it clusters a new CHS jet collection (ak4PFJetsCHSNoHF) which is used for its Type-1 correction consuming a non-negligible CPU time
  • No use cases at the moment therefore it can be removed from MiniAOD production workflow

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44335/39368

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

A new Pull Request was created by @wajidalikhan for master.

It involves the following packages:

  • DQM/Physics (dqm)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @rvenditti, @vlimant, @mandrenguyen, @hqucms, @nothingface0, @tjavaid, @jfernan2, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks.
@gkasieczka, @jdolen, @demuller, @gouskos, @jdamgov, @azotz, @mariadalfonso, @ahinzmann, @mbluj, @andrzejnovak, @seemasharmafnal, @AnnikaStein, @schoef, @mmarionncern, @rappoccio, @Senphy, @gpetruc, @hatakeyamak, @nhanvtran, @AlexDeMoor, @JyothsnaKomaragiri, @emilbols, @Ming-Yan this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Mar 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/37953/summary.html
COMMIT: d6b87f9
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44335/37953/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 76 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 791 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3293008
  • DQMHistoTests: Total failures: 196
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3292792
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@hqucms
Copy link
Contributor

hqucms commented Mar 7, 2024

+1

@mandrenguyen
Copy link
Contributor

+reconstruction
Thanks for the cleanup!

@cmsbuild
Copy link
Contributor

Pull request #44335 was updated. @cmsbuild, @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida, @rvenditti can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/38029/summary.html
COMMIT: ec72e46
CMSSW: CMSSW_14_1_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44335/38029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 787 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3296963
  • DQMHistoTests: Total failures: 196
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3296747
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@hqucms
Copy link
Contributor

hqucms commented Mar 20, 2024

@cms-sw/dqm-l2 Could you please have a look and sign it? Thank you!

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e466d0/38333/summary.html
COMMIT: ec72e46
CMSSW: CMSSW_14_1_X_2024-03-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44335/38333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 108 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 791 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3296949
  • DQMHistoTests: Total failures: 199
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3296730
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants