Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3 era for 2024 pp reference and UPC reco #44316

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR implements a first version of the Run 3 eras for the 2024 pp reference (at 5.36 TeV) and PbPb UPC reconstruction.

@mandrenguyen

PR validation:

Validated using a minbias sample.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44316/39336

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/PatAlgos (reconstruction, xpog)
  • RecoJets/Configuration (reconstruction)

@antoniovilela, @rappoccio, @vlimant, @fabiocos, @hqucms, @mandrenguyen, @davidlange6, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@demuller, @JanFSchulte, @AlexDeMoor, @AnnikaStein, @Ming-Yan, @mmarionncern, @andrzejnovak, @makortel, @nhanvtran, @seemasharmafnal, @mariadalfonso, @azotz, @dgulhan, @mtosi, @VinInn, @VourMa, @gkasieczka, @GiacomoSguazzoni, @felicepantaleo, @clelange, @rovere, @hatakeyamak, @jdamgov, @Martin-Grunewald, @rappoccio, @schoef, @fabiocos, @ahinzmann, @mbluj, @missirol, @Senphy, @gouskos, @mmusich, @gpetruc, @emilbols, @JyothsnaKomaragiri, @slomeo, @sameasy, @jdolen this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

@stahlleiton Normally we add a relVal workflow for testing. Do you want to give it a shot?
Can you list the cmsDriver commands you used for testing?
I recall that conditions were required for the low pT photon code.
Which GT were you using?

@stahlleiton
Copy link
Contributor Author

For the UPC, the only change was to modify the base era from Run3_2023 to Run3, and I tested it on 13_2_X. To test it in 14_1_X, a new GT will be needed (I can try to request one and add a MC relval for 14_1_X)

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Mar 6, 2024

Implemented 4 relval MC workflows:

  • 149.1: 2024 pp ref
  • 180: 2023 Pythia8 gamma-nucleus
  • 180.1: 2023 Starlight double diffraction
  • 181: 2024 Pythia8 gamma-nucleus

The Pythia8 gamma-nucleus workflows needs the fix implemented in #44264

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44316/39351

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

@AdrianoDee
Copy link
Contributor

test parameters:

  • workflows = 149.1, 180, 180.1, 181

@AdrianoDee
Copy link
Contributor

please test

@srimanob
Copy link
Contributor

+Upgrade

@stahlleiton
Copy link
Contributor Author

@bbilin and @menglu21 : please review/sign this PR

@menglu21
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3db8147 into cms-sw:master Mar 22, 2024
12 checks passed
@stahlleiton stahlleiton deleted the Run3_2024_ERA branch March 22, 2024 21:50
@makortel makortel mentioned this pull request Mar 25, 2024
@makortel
Copy link
Contributor

Workflow 180.1 fails in IBs, see #44536

@stahlleiton
Copy link
Contributor Author

Ok. I will try to update the gridpack of starlight. In the meantime, I will make a PR removing this workflow.

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Mar 25, 2024

Workflow 180.1 fails in IBs, see #44536

workflow disabled in #44540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants