-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rocm compilation of dev.cc files #107
Conversation
A new Pull Request was created by @ariostas for branch scramv3. @iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
Oops sorry @smuzaffar, I didn't see you had submitted a PR to fix this. Please close this PR if you prefer the other fix. |
test parameters:
|
please test |
@ariostas , this change was what I tried first but then looking closely I noticed that initially we wanted to use I ned to check with @fwyzard why we want to use |
IIRC, |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3be6e0/38472/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+external |
Fixed the issue described in #105. I just changed an if statement to make it match the cuda logic.
cmssw-config/SCRAM/GMake/Makefile.cuda
Line 87 in 95cbc7a
Closes #105, closes cms-sw/cmssw#44506.