Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alpaka/rocm rules; use hipcc linker for rocm #106

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 27, 2024

Fixes #105
Bug fix: Make sure to enable alpaka/rocm build rules if there is only .dev.cc files. Also use hipcc linker for binaries with rocm files .dev.cc or .hip.cc

FYI @fwyzard

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch scramv3.

@iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c11f12/38457/summary.html
COMMIT: 1053e8c
CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/106/38457/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c11f12/38457/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c11f12/38457/git-merge-result

Build

I found compilation error when building:

>> Cuda Device Link tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterCudaAsync/alpakaTestAtomicPairCounterCudaAsync_cudadlink.o 
>> Building alpaka/cuda binary alpakaTestAtomicPairCounterCudaAsync
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterCudaAsync/alpakaTestAtomicPairCounterCudaAsync to productstore area:
>> Building alpaka/rocm binary alpakaTestAtomicPairCounterROCmAsync
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/alpaka/testAtomicPairCounter.dev.cc.o: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/alpakaTestAtomicPairCounterROCmAsync
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/alpakaTestAtomicPairCounterROCmAsync] Error 1
>> Compiling alpaka/serial src/HeterogeneousCore/AlpakaInterface/test/alpaka/testAtomicPairCounter.dev.cc
>> Building alpaka/serial binary alpakaTestAtomicPairCounterSerialSync
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterSerialSync/alpakaTestAtomicPairCounterSerialSync to productstore area:


@cmsbuild
Copy link
Contributor

Pull request #106 was updated.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 27, 2024

please test

@cmsbuild
Copy link
Contributor

Pull request #106 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar merged commit a17a00f into scramv3 Mar 28, 2024
7 of 9 checks passed
@smuzaffar smuzaffar deleted the alpaka-rocm branch March 28, 2024 12:56
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c11f12/38487/summary.html
COMMIT: a1f4ddc
CMSSW: CMSSW_14_1_X_2024-03-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/106/38487/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpaka package fails to compile for ROCm when it has only .dev.cc files
2 participants