Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated btags and Working Points for Top Production mini AOD DQM #44299

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

dsidirop1
Copy link
Contributor

Description of PR

  • The main changes expected relate to the histograms on b-tagged jets for top production for miniAOD files now being filled (compared to previously being empty) after the btags were updated from the old CSV ones to the new DeepJet ones as described in the BTV Internal Wiki and also updates to the Medium Working Points used as described in the relevant BTV Internal Wiki page for 2023 Run3Summer23BPix.
  • There is no dependence on other PRs or externals.
  • BTV Internal Wiki
  • BTV Internal Wiki page for 2023 Run3Summer23BPix

PR validation

Changes have been made to the following files :

DQM/Physics/test/topDQM_production_miniAOD.py
DQM/Physics/src/TopSingleLeptonDQM_miniAOD.cc
DQM/Physics/src/SingleTopTChannelLeptonDQM_miniAOD.cc

Tests that have been performed to verify the correctness of the PR include running the topDQM_production_miniAOD.py file to produce a topDQM_production.root file and then the DQM/Physics/src/topDQM_harvesting_cfg.py to produce a DQM root file containing the tree with the relevant histograms that can be browsed. The correctness of the produced histograms was verified using the TBrowser root feature.

mtopbtagmuon.pdf
mtopbtagelectron.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44299/39319

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

A new Pull Request was created by @dsidirop1 for master.

It involves the following packages:

  • DQM/Physics (dqm)

@nothingface0, @syuvivida, @tjavaid, @cmsbuild, @antoniovagnerini, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Mar 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88859c/37902/summary.html
COMMIT: 8e014ec
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44299/37902/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • Reco comparison results: 59 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338250
  • DQMHistoTests: Total failures: 1430
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3336798
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.2899999999999987 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 0.094 KiB Physics/Top
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 00e3c5d into cms-sw:master Mar 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants