Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Make IncludeDY optional #39090

Merged
merged 5 commits into from
Aug 17, 2022
Merged

[Fix] Make IncludeDY optional #39090

merged 5 commits into from
Aug 17, 2022

Conversation

IzaakWN
Copy link
Contributor

@IzaakWN IzaakWN commented Aug 17, 2022

PR description

Make IncludeDY optional to fix for issues reported for PR #38829, e.g. #38829 (comment)

PR validation

Checked compilation with scram, code checks, code formats, and ran cmsRun.

Backports

Pushed the same fixes to the backports #38936 and #38938.

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Aug 17, 2022
@IzaakWN IzaakWN mentioned this pull request Aug 17, 2022
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39090/31605

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @IzaakWN (Izaak) for master.

It involves the following packages:

  • GeneratorInterface/Core (generators)
  • TauAnalysis/MCEmbeddingTools (simulation)

@SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

test parameters:

  • workflow = 136.9
  • addpkg = TauAnalysis/MCEmbeddingTools

@perrotta
Copy link
Contributor

please test

perrotta
perrotta reviewed Aug 17, 2022
View reviewed changes
TauAnalysis/MCEmbeddingTools/python/EmbeddingPythia8Hadronizer_cfi.py Outdated
@@ -19,7 +19,8 @@
MuHadCut = cms.string('Mu.Pt > 18 && Had.Pt > 25 && Mu.Eta < 2.1'),
MuMuCut = cms.string('Mu1.Pt > 17 && Mu2.Pt > 8'),
Final_States = cms.vstring('ElEl','ElHad','ElMu','HadHad','MuHad','MuMu'),
BosonPDGID = cms.int32(23)
BosonPDGID = cms.int32(23),
IncludeDY = cms.untracked.bool(True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that you want to set True as default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you are right. I was testing it True as well and forgot to update.

@perrotta
Copy link
Contributor

please abort

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39090/31606

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39090 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39090/31610

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39090 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@IzaakWN @perrotta
Remove "untracked".
cb2f977 
Co-authored-by: Andrea Perrotta <[email protected]>
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39090/31612

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39090 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@perrotta
Copy link
Contributor

please test

This was referenced Aug 17, 2022
Merged
Merged
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a42bf4/26883/summary.html
COMMIT: cb2f977
CMSSW: CMSSW_12_5_X_2022-08-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39090/26883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a42bf4/136.9_RunDoubleMuon2016C+RunDoubleMuon2016C+RAWRECOTE16+RAWRECOLHECLEANTE16+EMBEDHADTE16+EMBEDMINIAOD16

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692500
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • The previosly failing workflow and unit tests now succed
  • Let have this merged to remove the errors from the IBs
  • @cms-sw/generators-l2 @cms-sw/simulation-l2 : the fix is quite simple, let me bypass your signature here

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5d29539 into cms-sw:master Aug 17, 2022
@qliphy qliphy mentioned this pull request Aug 18, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved generators-pending orp-approved pending-signatures simulation-pending tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
3 participants
@IzaakWN @cmsbuild @perrotta