-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change Selector from bit pattern to bit number for the pattern [12.5] #38948
change Selector from bit pattern to bit number for the pattern [12.5] #38948
Conversation
@vlimant, CMSSW_12_5_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31389
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
assign xpog |
@smuzaffar is the a “please patch” command that we could have to push the patch as a PR to my branch? |
good idea @vlimant , yes we can improve bot to patch the user branch on demand (e.g. using I will look in to it once back from vacations ( after 10th Aug) |
from PR code check cms-sw#38948 (comment)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31419
|
New categories assigned: xpog @mariadalfonso,@gouskos,@swertz,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @vlimant (vlimant) for master. It involves the following packages:
@gouskos, @swertz, @vlimant, @clacaputo, @cmsbuild, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1f44/26644/summary.html Comparison SummarySummary:
|
please test with #39090 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1f44/26892/summary.html Comparison SummarySummary:
|
+reconstruction
|
@cms-sw/dqm-l2 @cms-sw/xpog-l2 you already signed the backport PR in 12_4_X, I imagine you could also sign this master version of it... |
+xpog |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
from PR code check cms-sw#38948 (comment)
from PR code check cms-sw#38948 (comment)
PR description:
forward part of #38943 to 12.5