change Selector from bit pattern to bit number for the pattern [12.5]

[vlimant]

PR description:

forward part of #38943 to 12.5

[cmsbuild]

@vlimant, CMSSW_12_5_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31389

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31389/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31389/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mariadalfonso]

assign xpog

[vlimant]

@smuzaffar is the a “please patch” command that we could have to push the patch as a PR to my branch?

[smuzaffar]

@smuzaffar is the a “please patch” command that we could have to push the patch as a PR to my branch?

good idea @vlimant , yes we can improve bot to patch the user branch on demand (e.g. using please patch or apply code-checks). Note that this will only work if user has allowed owner of cms-sw to apply changes to PR branch.

I will look in to it once back from vacations ( after 10th Aug)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38948/31419

• This PR adds an extra 20KB to repository

[cmsbuild]

New categories assigned: xpog

@mariadalfonso,@gouskos,@swertz,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @vlimant (vlimant) for master.

It involves the following packages:

• DataFormats/MuonReco (reconstruction)

@gouskos, @swertz, @vlimant, @clacaputo, @cmsbuild, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@sscruz, @Fedespring, @battibass, @abbiendi, @rovere, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @amagitte, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1f44/26644/summary.html
COMMIT: 3d74cfb
CMSSW: CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38948/26644/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 263 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691510
• DQMHistoTests: Total failures: 1300
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3690187
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[qliphy]

please test with #39090

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1f44/26892/summary.html
COMMIT: 739829a
CMSSW: CMSSW_12_5_X_2022-08-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38948/26892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 149 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692500
• DQMHistoTests: Total failures: 1341
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691137
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• fix for Problem parsing the enum in reco::Muon::Selector #38899
• changes to NANO muons and nothing else

[perrotta]

@cms-sw/dqm-l2 @cms-sw/xpog-l2 you already signed the backport PR in 12_4_X, I imagine you could also sign this master version of it...

[mariadalfonso]

+xpog

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1