[GCC Flags] drop -Wstrict-overflow which has been deprecated since gcc8

[smuzaffar]

-Wstrict-overflow is deprecated and using -fsanitize=signed-integer-overflow is now the preferred way to audit code (see cms-sw/cmssw#38679 (comment) )

This PR proposes to drop this flag

[smuzaffar]

test parameters:

• full_cmssw = true

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_5_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26888/summary.html
COMMIT: bec6d96
CMSSW: CMSSW_12_5_X_2022-08-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8026/26888/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoHI cmssw#38954
• @bsunanda Run3-alca226 Update the macros to e used for Run3 analysis of hadron calorimeter calibration data with isolated muons cmssw#39063
• @mandrenguyen tighter selection in pp_on_AA era for iterations still using pp defaults cmssw#39085
• @fwyzard Rename inline c++ files to .icc cmssw#38904
• @mmusich fix run-by-run TkAlignment PV Validation submission script in case of extra conditions cmssw#39091
• @makortel Initialize BranchDescription from Dictionary only if the branch is present cmssw#38806
• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoEcal cmssw#38786
• @trackreco mkFit updates aiming to improve pixelLess iteration and related cmssw#39055

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26888/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26888/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 17560 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692500
• DQMHistoTests: Total failures: 23451
• DQMHistoTests: Total nulls: 5
• DQMHistoTests: Total successes: 3669022
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.012 KiB( 50 files compared)
• DQMHistoSizes: changed ( 138.4,... ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: found differences in 2 / 50 workflows

[smuzaffar]

please test for CMSSW_12_5_CLANG_X

[smuzaffar]

abort

[smuzaffar]

please test for CMSSW_12_5_LTO_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26902/summary.html
COMMIT: bec6d96
CMSSW: CMSSW_12_5_LTO_X_2022-08-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8026/26902/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoHI cmssw#38954
• @IzaakWN [Fix] Make IncludeDY optional cmssw#39090
• @gartung Utilities/StaticAnalyzers: Only skip edm::one modules for use of TFileService functions in statics2modules reports. cmssw#39072
• @makortel Add more profile dump points to IgProfService cmssw#39073
• @bsunanda Run3-alca226 Update the macros to e used for Run3 analysis of hadron calorimeter calibration data with isolated muons cmssw#39063
• @ChrisMisan Fix PPSDiamondDQM histogram of rechits in the last lumisection cmssw#39076
• @mandrenguyen tighter selection in pp_on_AA era for iterations still using pp defaults cmssw#39085
• @fwyzard Rename inline c++ files to .icc cmssw#38904
• @atsatsos97 DQM for DiPhoton Paths in EXO/HIG PAGs cmssw#39093
• @mmusich SiPixelLorentzAnglePCLHarvester: protect the computation of the LA error in case of missing covariance matrix cmssw#39083
• @mmusich fix run-by-run TkAlignment PV Validation submission script in case of extra conditions cmssw#39091
• @makortel Initialize BranchDescription from Dictionary only if the branch is present cmssw#38806
• @IzaakWN Add DY option to Embedding HepMC filter cmssw#38829
• @slava77 switch pixelLess iteration to use CKF instead of mkFit cmssw#38967
• @trackreco mkFit updates aiming to improve pixelLess iteration and related cmssw#39055
• @mmusich add states to GsfMultiStateUpdator MultiState only if the localError matrix is valid cmssw#39056
• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoEcal cmssw#38786

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26902/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b956a/26902/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreFrameworkeventprocessor had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.2 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 23566 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692140
• DQMHistoTests: Total failures: 44381
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3647734
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 975.5360000000001 KiB( 50 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 108.078 KiB HLT/EXO
• DQMHistoSizes: changed ( 11634.0,... ): 54.512 KiB HLT/HIG
• DQMHistoSizes: changed ( 138.4 ): -0.004 KiB JetMET/SUSYDQM
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: found differences in 3 / 50 workflows

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)