-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Geometry_cff with GeometryDB_cff in RecoEcal #38786
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38786/31139
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e67db/26327/summary.html Comparison SummarySummary:
|
Dear @cms-sw/ecal-dpg-l2 , it seems to me the config files fixed by this PR aren't updated since |
A kind ping to @cms-sw/ecal-dpg-l2 , please, if you can have a look. Thanks |
Hi @thomreis, could you please have a look at these cfgs and check with ecal people whether they are still needed? Thanks |
Hi @clacaputo these test config files are not needed anymore as far as I can tell and can be removed. |
Thanks, @thomreis . @jeongeun , could you please take care of it? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38786/31597
|
Pull request #38786 was updated. @jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e67db/26865/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Review on the Reco part of #31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, RecoEcal configuration files (2 files) are fixed.
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions