Run3-alca226 Update the macros to e used for Run3 analysis of hadron calorimeter calibration data with isolated muons

[bsunanda]

PR description:

Update the macros to e used for Run3 analysis of HCAL calibration data with isolated muons

PR validation:

Use the macros to analyze Run3 calibration data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31566

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type hcal

[ChrisMisan]

@bsunanda please squash the commits

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76446b/26826/summary.html
COMMIT: 592b4a9
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39063/26826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692476
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692446
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

@bsunanda I have a couple comments for possible future improvements of the code, they're applying to the whole HcalCalibAlgos.

There is a lot of code which abuses if statement, this can all go into one loop:

cmssw/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc

Line 682 in 7654b67

if (ipsall - ips0 == mypow_2[ncut] - mypow_2[0] - 1) {

There is no reason why those kind of variables shouldn't be an array:

cmssw/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc

Line 410 in 7654b67

int ipsall = 0;

There's a lot of commented lines which doesn't make sense syntax-wise when uncommented:

cmssw/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc

Line 1001 in 7654b67

} //for (HOCalibVariableCollection::const_iterator hoC=(*HOCalib).begin(); hoC!=(*HOCalib).end(); hoC++){

Instead of using preprocessor directives you should consider using a flag exposed to the python configuration:

cmssw/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc

Line 395 in 7654b67

#ifdef EDM_ML_DEBUG

There is a lot of memory management issues, for example in this file:
https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/AnalyzeLepTree.C

maybe it'd be better to use smart pointers instead of manually managing the memory?

Please consider using unordered sets and maps when ordering is not necessary:
https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/AnalyzeLepTree.C

Initializations could be inlined:

cmssw/Calibration/HcalCalibAlgos/macros/HBHEMuonHighEta.C

Line 318 in 592b4a9

pt_of_muon = 0;

There are comments which are misleading or incorrect:

cmssw/Calibration/HcalCalibAlgos/macros/HBHEMuonHighEta.C

Line 547 in 592b4a9

// This function may be called from Loop.

[bsunanda]

@ChrisMisan I am squashing this right now. I shall slowly update the other parts as pointed out by you

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31598

• This PR adds an extra 8KB to repository

[cmsbuild]

Pull request #39063 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76446b/26864/summary.html
COMMIT: fb3e72d
CMSSW: CMSSW_12_5_X_2022-08-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39063/26864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692500
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• PR in line with the description
• differences in MTD and msgLogger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1