Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[106X backport] Add DY option to Embedding HepMC filter #38936

Merged

Conversation

IzaakWN
Copy link
Contributor

@IzaakWN IzaakWN commented Aug 2, 2022

PR description

Backport of PR #38829

PR validation

See PR #38829 and https://indico.cern.ch/event/1170879/#2-validation-of-exclusive-dy-t

PR backporting

Backporting to CMSSW_10_6_X, beause we would like to reproduce the DYJetsToTauTauToMuTauh_M-50 sample for Run-2 UL MC for TauPOG studies, and allow the H → WW analysis to use this updated filter.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

A new Pull Request was created by @IzaakWN (Izaak) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@IzaakWN IzaakWN changed the title [124X backport] Add DY option to Embedding HepMC filter [106X backport] Add DY option to Embedding HepMC filter Aug 2, 2022
@SiewYan
Copy link
Contributor

SiewYan commented Aug 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1be0a/26593/summary.html
COMMIT: 7709205
CMSSW: CMSSW_10_6_X_2022-07-31-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38936/26593/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

please abort

@perrotta
Copy link
Contributor

test parameters:

  • workflow = 136.9
  • addpkg = TauAnalysis/MCEmbeddingTools

@perrotta
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

backport of #38829

@perrotta
Copy link
Contributor

(It also backports #39090, which must be succesfully tested and merged in the master before this one)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1be0a/26885/summary.html
COMMIT: 2a59073
CMSSW: CMSSW_10_6_X_2022-08-14-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38936/26885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Aug 18, 2022

+1

@qliphy
Copy link
Contributor

qliphy commented Aug 22, 2022

@cms-sw/generators-l2 Do you have any further comment?

@Saptaparna
Copy link
Contributor

No further comments. +1

@qliphy
Copy link
Contributor

qliphy commented Aug 22, 2022

+generators
see above

@qliphy
Copy link
Contributor

qliphy commented Aug 22, 2022

merge

@cmsbuild cmsbuild merged commit ce0e768 into cms-sw:CMSSW_10_6_X Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants