consistent implementation of nano step for Run 3

[kpedro88]

PR description:

Supersedes #36050 to fix #35966 by redoing #35412 in a consistent way. All special workflows that target Run 3 scenarios are updated to handle the new Nano-related steps.

PR validation:

Checked both relval and production-like workflows to see that the desired steps are created.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36167/26724

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Fix prodlike workflows #36050, Add PilotBeam data in relval matrix tests #36133, Python3syntaxupgrade #36160, Add DQM Matrix to RelVals #35678
  • File Configuration/PyReleaseValidation/python/relval_upgrade.py modified in PR(s): Fix prodlike workflows #36050
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Fix prodlike workflows #36050, Add run3 tracking low pu era #33532, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

test parameters:
workflow = 11834.21
relvals_opt = -w upgrade

[kpedro88]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-827954/20610/summary.html
COMMIT: 8567468
CMSSW: CMSSW_12_2_X_2021-11-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36167/20610/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

[kpedro88]

@smuzaffar it seems like adding -w upgrade prevented it from running the normal matrix tests. I thought this had worked in the past. Is there a different setting needed?

[smuzaffar]

@kpedro88 , I don't think it ever worked. The only way is to explicitly pass -w <comma,separated,list,of,other,works,>upgrade . Note that there are some sets which define the same workflow number. So it is bit tricky to get the correct list

[kpedro88]

okay, i'm just going to add it to the regular matrix.

[kpedro88]

test parameters:
workflow = 11834.21

[cmsbuild]

Pull request #36167 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-827954/20688/summary.html
COMMIT: 469b45f
CMSSW: CMSSW_12_2_X_2021-11-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36167/20688/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-827954/11834.21_TTbar_14TeV+2021PU_ProdLike+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoNanoPU+MiniAODPU+NanoPU

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2206928
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2206900
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

would be nice to have this PR soon, so that next integrations of the nano in view of Run3 are validated in the runTheMatrix
@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 : is there something more to check ?

[kskovpen]

+1

[srimanob]

+Upgrade

This PR is to take care Nano step to run properly in relvals. PR test runs fine and the result is expected (No change).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[slava77]

apparently this broke GPU workflows
runTheMatrix.py -w gpu -n -e -l 11634.506 had 4 steps in CMSSW_12_2_X_2021-11-29-1100 and only 2 steps in CMSSW_12_2_X_2021-11-29-2300 and the only relevant change seems to be from this PR.

@cms-sw/heterogeneous-l2

[kpedro88]

@slava77 thanks for spotting this, see #36309