Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SiPixel LA PCL naming in autoPCL file #36182

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 19, 2021

PR description:

Inspired by the mistake in dmwm/T0#4635 (review)
We propose to rename this mapping to be consistent with the wf name. It is necessary in order for the ALCAHarvesting step to succeed, see dmwm/T0#4635 (comment) as autoPCL is used in the ConfigBuilder.

PR validation:

Tried to run
runTheMatrix.py -l 1001.2

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tvami tvami changed the title Change SiPixel LA PCL naming Change SiPixel LA PCL naming in autoPCL file Nov 19, 2021
@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Nov 19, 2021
@tvami
Copy link
Contributor Author

tvami commented Nov 19, 2021

test parameters:

  • workflows = 1001.2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36182/26757

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 19, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfce6a/20629/summary.html
COMMIT: 59e8b24
CMSSW: CMSSW_12_2_X_2021-11-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36182/20629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bfce6a/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3327156
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3327134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

+alca

  • changes inline with PR description

@mmusich
Copy link
Contributor

mmusich commented Nov 20, 2021

type bug-fix

@srimanob
Copy link
Contributor

+Upgrade

Technical PR of naming. PR test runs fine with no change.

@bbilin
Copy link
Contributor

bbilin commented Nov 20, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants