-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SiPixel LA PCL naming in autoPCL file #36182
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36182/26757
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfce6a/20629/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
type bug-fix |
+Upgrade Technical PR of naming. PR test runs fine with no change. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Inspired by the mistake in dmwm/T0#4635 (review)
We propose to rename this mapping to be consistent with the wf name. It is necessary in order for the ALCAHarvesting step to succeed, see dmwm/T0#4635 (comment) as autoPCL is used in the ConfigBuilder.
PR validation:
Tried to run
runTheMatrix.py -l 1001.2
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A