Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LA harvester to 1001.2 wf #36245

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add LA harvester to 1001.2 wf #36245

merged 1 commit into from
Nov 25, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 24, 2021

PR description:

It came up here
#36241 (comment)
that the wf 1001.2 doesnt have the LA harvester step. This PR adds that.

PR validation:

runTheMatrix.py -l 1001.2 -j 0

is now giving

 cmsDriver.py step5  -s ALCAHARVEST:SiPixelLA --conditions auto:run3_data_express --scenario pp --data  --era Run2_2017 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n 100  --no_exec --fileout file:step5.root  > step5_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA.log  2>&1

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36245/26882

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 24, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5abfd2/20750/summary.html
COMMIT: c4cda60
CMSSW: CMSSW_12_2_X_2021-11-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36245/20750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247025
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

Should we test 1001.2 as an additional step introduced in this PR? @tvami @kskovpen
I don't see it in short matrix test,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5abfd2/20750/runTheMatrix-results/

@kskovpen
Copy link
Contributor

Should we test 1001.2 as an additional step introduced in this PR? @tvami @kskovpen
I don't see it in short matrix test,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5abfd2/20750/runTheMatrix-results/

I agree, let's test it explicitly here as well.

@kskovpen
Copy link
Contributor

test parameters:

  • workflow = 1001.2

@kskovpen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5abfd2/20754/summary.html
COMMIT: c4cda60
CMSSW: CMSSW_12_2_X_2021-11-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36245/20754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5abfd2/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247745
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Nov 25, 2021

+Upgrade

This PR is to add an additional ALCA step to a specific workflow, 1001.2. The PR test runs fine.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1c74a68 into cms-sw:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants