Unfork CosmosSDK, CometBFT, ibc-go #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder (#26) * bet * bet * Fix test oracle * update ict * revert unnecessary change * update test * Refactor test --------- Co-authored-by: tnv1 <[email protected]>
* feat: unfork cachesize setting * feat: handleBlockHeightMiddleware * feat: add hook for validator power limit * perf: change hooks ordering * revert toolchain * bump to sdk 47.14 * comments for option
…unfork-cosmossdk-cometbft
* bump * add ibc ante spamming * bump ibc-go to v7.4.1 * make default max memo length 1024 --------- Co-authored-by: Tuan Tran <[email protected]>
feat: unfork cometbft, cosmos-sdk, ibc-go
There was a problem hiding this comment.
Copilot reviewed 20 out of 35 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- Makefile: Language not supported
- go.mod: Language not supported
- scripts/run-node.sh: Language not supported
- scripts/spam-tx.sh: Language not supported
- scripts/upgrade-test.sh: Language not supported
- custom/auth/ante/fee.go: Evaluated as low risk
- custom/auth/ante/ante.go: Evaluated as low risk
- custom/auth/ante/fee_tax.go: Evaluated as low risk
- app/keepers/keepers.go: Evaluated as low risk
- cmd/terrad/config.go: Evaluated as low risk
- app/mempool/helper_test.go: Evaluated as low risk
- app/app.go: Evaluated as low risk
- app/upgrades/v11/constants.go: Evaluated as low risk
- cmd/terrad/config_test.go: Evaluated as low risk
- app/mempool/mempool_fifo.go: Evaluated as low risk
Comments skipped due to low confidence (2)
custom/auth/ante/ibc_spamming_prevention.go:17
- [nitpick] The error message 'receiver too long' could be more descriptive. Consider changing it to 'Receiver address exceeds maximum allowed length'.
ErrReceiverTooLong = sdkerrors.Register(ModuleName, 11, "receiver too long")
custom/auth/ante/ibc_spamming_prevention.go:18
- [nitpick] The error message 'memo too long' could be more descriptive. Consider changing it to 'Memo exceeds maximum allowed length'.
ErrMemoTooLong = sdkerrors.Register(ModuleName, 12, "memo too long")
StrathCole
reviewed
Dec 5, 2024
kien6034
changed the title
StrathCole
merged commit 70aad84
into
classic-terra:orbitlabs/unforking
38 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR unforks the following modules:
CosmosSDK
DefaultIAVLCacheSizesetting from fork to Terrad Issue 14IBC
Comet BFT
terradUnit testing
Cosmos-sdk
ibc-go
CometBFT
E2E testings
CometBFT
Report of required housekeeping
(FOR ADMIN) Before merging