feat: unfork cometbft, cosmos-sdk, ibc-go #16
Conversation
TropicalDog17
changed the title
| @@ -118,7 +118,10 @@ func computeTax(ctx sdk.Context, tk TreasuryKeeper, principal sdk.Coins, simulat | |||
| return taxes | |||
| } | |||
|
|
|||
| func isOracleTx(msgs []sdk.Msg) bool { | |||
| func IsOracleTx(msgs []sdk.Msg) bool { | |||
There was a problem hiding this comment.
Remember to put this function to some other file as it is now used not only in fee calculation.
| @@ -9,7 +11,7 @@ require ( | |||
| github.com/CosmWasm/wasmd v0.46.0 | |||
| github.com/CosmWasm/wasmvm v1.5.5 | |||
| github.com/cometbft/cometbft v0.37.4 | |||
| github.com/cometbft/cometbft-db v0.8.0 | |||
| github.com/cometbft/cometbft-db v0.11.0 | |||
There was a problem hiding this comment.
If you change to cometbft this also allows compiling in pebbledb. Maybe you can include that build option to the make file. See https://github.com/NibiruChain/nibiru/pull/1818/files
There was a problem hiding this comment.
ah yeah, we upgrade cometbft to v0.37.13, will upgrade the make file
* feat: unfork cachesize setting * feat: handleBlockHeightMiddleware * feat: add hook for validator power limit * perf: change hooks ordering * revert toolchain * bump to sdk 47.14 * comments for option
go.mod
Outdated
| @@ -1,4 +1,6 @@ | |||
| go 1.20 | |||
| go 1.22.7 | |||
There was a problem hiding this comment.
Be careful with bumping go requirements. This has to be very explicitly communicated during tests and deployment, because many validators and nodes run on 1.20
There was a problem hiding this comment.
yeah, i think we can also update Go to the latest version (include security fixes and performance improve)
There was a problem hiding this comment.
I have nothing against this, but we need to make that 100% clear to all validators in the release notes and upgrade instructions.
| func (mp *FifoMempool) Insert(_ context.Context, tx sdk.Tx) error { | ||
| mp.updateMtx.RLock() | ||
| defer mp.updateMtx.RUnlock() | ||
| totalTxs := mp.txs.Len() + mp.txsOracle.Len() |
There was a problem hiding this comment.
I just re-checked the current mempool. It seems that oracle txs are not calculated towards the size.
Check:
https://github.com/classic-terra/cometbft/blob/v0.37.4-terra1/mempool/v0/clist_mempool.go#L147
Which only uses mem.txs and not mem.oracleTxs
And on size check:
https://github.com/classic-terra/cometbft/blob/v0.37.4-terra1/mempool/v0/clist_mempool.go#L228
which calls https://github.com/classic-terra/cometbft/blob/v0.37.4-terra1/mempool/v0/clist_mempool.go#L384
only the size is checked which ignores oracle txs.
There was a problem hiding this comment.
you can see here -> https://github.com/classic-terra/cometbft/blob/v0.37.4-terra1/mempool/v0/clist_mempool.go#L330-L339
the txs include regular txs and oracle txs
There was a problem hiding this comment.
I am sorry, you're right. I overlooked that part. 👍
hoank101
changed the title
* bump * add ibc ante spamming * bump ibc-go to v7.4.1 * make default max memo length 1024 --------- Co-authored-by: Tuan Tran <[email protected]>
Closes #2
Closes #1
The default of FifoMempool size is 5000
if need modify it, please config