Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test override config cache size #30

Merged
merged 1 commit into from
Nov 27, 2024
Merged

test: add test override config cache size #30

merged 1 commit into from
Nov 27, 2024

Conversation

tnv1
Copy link

@tnv1 tnv1 commented Nov 27, 2024 •
edited by TropicalDog17
Loading

Summary of changes

closes #23

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@tnv1 tnv1 marked this pull request as ready for review November 27, 2024 17:20
@TropicalDog17 TropicalDog17 self-requested a review November 27, 2024 17:33
TropicalDog17
TropicalDog17 approved these changes Nov 27, 2024
View reviewed changes
Copy link

@TropicalDog17 TropicalDog17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TropicalDog17 TropicalDog17 merged commit 1875d99 into feat/unfork-cosmossdk-cometbft Nov 27, 2024
14 of 21 checks passed
@tnv1 tnv1 deleted the test-sdk branch December 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TropicalDog17 TropicalDog17 TropicalDog17 approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
Phase 1: Unfork CometBFT and Cosmos SDK
Development

Successfully merging this pull request may close these issues.
2 participants
@tnv1 @TropicalDog17