Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] BlockHeightMiddleware #24

Closed
5 tasks
Tracked by #5 ...
kien6034 opened this issue Nov 10, 2024 · 0 comments
Closed
5 tasks
Tracked by #5 ...

[test] BlockHeightMiddleware #24

kien6034 opened this issue Nov 10, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed testing

Comments

@kien6034
Copy link

Problem definition
Related issues: #13

Commit changes:
8f92d8d

Testing
The test should verify that the BlockHeightMiddleware correctly:

  • Parses the height query parameter
  • Sets the GRPCBlockHeightHeader appropriately
  • Handles error cases properly

Acceptance criteria
Specificy the desired outcomes of resolving this issue.

  • Valid height parameters are correctly propagated to the GRPCBlockHeightHeader
  • Invalid height formats return appropriate syntax errors
  • Negative heights are properly rejected
  • Zero height queries are handled correctly
  • Empty height parameter allows the request to pass through unchanged
@kien6034 kien6034 added enhancement New feature or request help wanted Extra attention is needed testing and removed enhancement New feature or request labels Nov 10, 2024
@tnv1 tnv1 self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

3 participants