Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons looks fuzzy on Firefox 57 (Quantum) #668

Closed
jodator opened this issue Nov 16, 2017 · 6 comments Β· Fixed by ckeditor/ckeditor5-ui#341
Closed

Icons looks fuzzy on Firefox 57 (Quantum) #668

jodator opened this issue Nov 16, 2017 · 6 comments Β· Fixed by ckeditor/ckeditor5-ui#341
Assignees
Labels
package:theme-lark package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Nov 16, 2017

🐞 Is this a bug report or feature request? (choose one)

  • Bug report

πŸ’» Version of CKEditor

Latest master.

πŸ“‹ Steps to reproduce

  1. Open editor on Firefox 57.
  2. Lookup toolbar icons.

βœ… Expected result

Chrome:
selection_020

❎ Actual result

Firefox 57 (Quantum) / Linux Mint 18.2 (Sonya):
selection_019

πŸ“ƒ Other details that might be useful

I don't remember how that looked on previous Firefox.

@dkonopka
Copy link
Contributor

dkonopka commented Nov 16, 2017

As I see this fix is working (I think new Firefox is buggy with rendering 1px width/height points):

svg.ck-icon { 
     transform: translate3d( 0, 0, 0 ); 
}

@jodator
Copy link
Contributor Author

jodator commented Nov 16, 2017

I can confirm that it works for main toolbar icons but not with icons in dropdown:
selection_021

When disabled translate3d( 0, 0, 0 ) in dev tools:
selection_024
(the align right icon looks OK... but only this one)

@dkonopka
Copy link
Contributor

dkonopka commented Nov 16, 2017

We can also try a new fix for "blurred" elements:

will-change: transform;

but currently, it's not supported for IE/Edge .

The status of Will Change @Edge - still under consideration.

@jodator jodator changed the title Icons looks fuzzy on Firefox 58 (Quantum) Icons looks fuzzy on Firefox 57 (Quantum) Nov 16, 2017
@Reinmar
Copy link
Member

Reinmar commented Nov 16, 2017

Icons were always fuzzy in Firefox. It's not something new (not a regression caused by Quantum).

@dkonopka
Copy link
Contributor

dkonopka commented Nov 16, 2017

@jodator .ck-dropdown__panel needs fix too then.

will-change: transform

Anyway every translate property in CSS should be changed to translate3d (or will-change).

screen shot 2017-11-16 at 11 04 40

@oleq
Copy link
Member

oleq commented Nov 16, 2017

PR please ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:theme-lark package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants