T/144: Migrated the package from SASS to PostCSS #345
Conversation
theme/components/tooltip/tooltip.css
Outdated
| .ck-tooltip__text::after { | ||
| position: absolute; | ||
|
|
||
| /*Without this, hovering the tooltip could keep it visible.*/ |
There was a problem hiding this comment.
Missing spaces in this and other comments here.
theme/components/tooltip/tooltip.css
Outdated
| content: ""; | ||
| width: 0; | ||
| height: 0; | ||
| } |
There was a problem hiding this comment.
What do you think about using a nesting here?
.ck-tooltip__text {
display: inline-block;
&::after {
content: "";
width: 0;
height: 0;
}
}
| width: auto; | ||
| height: auto; | ||
| position: static; | ||
| } |
There was a problem hiding this comment.
theme/mixins/_unselectable.css
Outdated
| -moz-user-select: none; | ||
| -webkit-user-select: none; | ||
| -ms-user-select: none; | ||
| } |
There was a problem hiding this comment.
Missing default user-select: none:
@define-mixin ck-unselectable {
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none
}Since Chrome 60 is using user-select not -webkit-user-select: none.
| .ck-editor { | ||
| & .ck-sticky-panel { | ||
| & .ck-sticky-panel__content_sticky { | ||
| z-index: var(--ck-z-modal); /*#315*/ |
There was a problem hiding this comment.
Missing spaces in the 🗒 .
|
|
||
| &.ck-balloon-panel_with-arrow { | ||
| &:before, | ||
| &:after { |
There was a problem hiding this comment.
We should use a double colon for pseudo-elements instead of one.
theme/components/tooltip/tooltip.css
Outdated
| pointer-events: none; | ||
|
|
||
| /*This is to get rid of flickering when transitioning opacity in Chrome. | ||
| It's weird but it works.*/ |
theme/components/dropdown.css
Outdated
|
|
||
| position: absolute; | ||
| top: 50%; | ||
| transform: translate( 0, -50% ); |
There was a problem hiding this comment.
Here we should consider using translate3d -> Icons looks fuzzy on Firefox.
There was a problem hiding this comment.
I'll review, migrate to PostCSS and merge #341 after this PR.
theme/components/dropdown.css
Outdated
| } | ||
|
|
||
| .ck-dropdown__panel-visible { | ||
| display: inline-block; |
There was a problem hiding this comment.
Adding will-change: transformis helping -> Icons looks fuzzy on Firefox
theme/components/dropdown.css
Outdated
|
|
||
| position: absolute; | ||
| left: 0px; | ||
| transform: translateY( 100% ); |
Suggested merge commit message (convention)
Other: Migrated the package from SASS to PostCSS to bring theme support and avoid duplicates. Closes ckeditor/ckeditor5#5304. Closes ckeditor/ckeditor5#420.
BREAKING CHANGE: The styles are no longer developed in SASS which means the
.scssfiles became unavailable. Please refer to the Theme Customization guide to learn more about migration to PostCSS.Additional information
Lark:
Other PRs: