[Umbrella][Firefox] Compatibility with Firefox 57 (Quantum)

[oleq]

Mozilla is about to release their Firefox with a brand–new engine.

I ran tests and there are some failures outside ckeditor5-engine + I wasn't able to run engine tests due to some karma issues.

The issues, of course, must be addressed and the stability of the editor verified.

The output of failing tests from Karma

  StandardEditor
    attaching to a form
      ✖ should not replace submit() method when one of the elements in a form is named "submit"
        Firefox 57.0.0 (Mac OS X 10.12.0)
      expected [Function] to equal <input name="submit">

      + expected - actual

      -[Function]
      +{}

AssertionError@node_modules/chai/chai.js:9320:13
[3]</module.exports/Assertion.prototype.assert@node_modules/chai/chai.js:239:13
assertEqual@node_modules/chai/chai.js:1383:7
methodWrapper@node_modules/chai/chai.js:7709:18
@packages/ckeditor5-core/tests/editor/standardeditor.js:46825:6



  ImageEngine
    conversion in data pipeline
      model to view
        ✖ should convert srcset attribute to width, srcset and add sizes attribute
          Firefox 57.0.0 (Mac OS X 10.12.0)
        expected '<figure class="image"><img srcset="small.png 148w, big.png 1024w" sizes="100vw" alt="alt text" src="foo.png" width="1024"></figure>' to equal '<figure class="image"><img srcset="small.png 148w, big.png 1024w" sizes="100vw" width="1024" alt="alt text" src="foo.png"></figure>'

      + expected - actual

      -<figure class="image"><img srcset="small.png 148w, big.png 1024w" sizes="100vw" alt="alt text" src="foo.png" width="1024"></figure>
      +<figure class="image"><img srcset="small.png 148w, big.png 1024w" sizes="100vw" width="1024" alt="alt text" src="foo.png"></figure>

AssertionError@node_modules/chai/chai.js:9320:13
[3]</module.exports/Assertion.prototype.assert@node_modules/chai/chai.js:239:13
assertEqual@node_modules/chai/chai.js:1383:7
methodWrapper@node_modules/chai/chai.js:7709:18
@packages/ckeditor5-image/tests/image/imageengine.js:48523:5



  Bogus BR integration
    insertText
      ✖ space is inserted on the end of the line (paragraph)
        Firefox 57.0.0 (Mac OS X 10.12.0)
      Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ space is inserted on the end of the line (empty paragraph)
        Firefox 57.0.0 (Mac OS X 10.12.0)
      Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ space is inserted on the end of the line (bold)
        Firefox 57.0.0 (Mac OS X 10.12.0)
      Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  Spellchecking integration
    Plain text spellchecking (insertText)
      ✖ should replace with longer word (collapsed)
        Firefox 57.0.0 (Mac OS X 10.12.0)
      Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

    ✖ "before each" hook for "should replace with longer word (non-collapsed)"
      Firefox 57.0.0 (Mac OS X 10.12.0)
    expected '<paragraph>[]The Foo hous a is a Foo hous e. A Foo athat and Foo xhat. This is an istane</paragraph><paragraph>Banana, orenge, appfle and the new comppputer</paragraph>' to equal '<paragraph>The Foo house[] a is a Foo hous e. A Foo athat and Foo xhat. This is an istane</paragraph><paragraph>Banana, orenge, appfle and the new comppputer</paragraph>'

      + expected - actual

      -<paragraph>[]The Foo hous a is a Foo hous e. A Foo athat and Foo xhat. This is an istane</paragraph><paragraph>Banana, orenge, appfle and the new comppputer</paragraph>
      +<paragraph>The Foo house[] a is a Foo hous e. A Foo athat and Foo xhat. This is an istane</paragraph><paragraph>Banana, orenge, appfle and the new comppputer</paragraph>

---

Other issues found after the release of Quantum:

• A problem with blurry icons Icons looks fuzzy on Firefox 57 (Quantum) #668.

[Reinmar]

During the last testing phase there were some failing tests too, so that's not new. Actually, it seems like exactly the same tests fail.

[Reinmar]

Also see #573 (comment).

Nevertheless, this is a new major FF release, so some testing will be nice.

[oleq]

During the last testing phase there were some failing tests too, so that's not new. Actually, it seems like exactly the same tests fail.

That's a great news actually. Usually, a new engine means lots of trouble.

[oleq]

There's a problem with blurry icons #668.

[Reinmar]

I think we did enough testing already and fixed or at least reported some new issues.