-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui-shell): fix onclick menu bugs #5274
fix(ui-shell): fix onclick menu bugs #5274
Conversation
Deploy preview for carbon-components-react ready! Built with commit 366df08 https://deploy-preview-5274--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 366df08 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @tw15egan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tw15egan, i saw we have a lots of SVG have this property will-change: transform. I think we should investigate what is actual behavior of it. How do you think ? |
@xxxle0 agreed, would like to know why this is causing issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why will-change
needs to be on our icons by default, but if it's not necessary we could remove it from the icon builder package instead of overriding in UI shell
@emyarod I'm not sure why it is there by default either, @joshblack any idea where that attribute is coming from/if it is needed? |
Ah yeah, it has a specific purpose for rendering correctly in Firefox 😞 Reference: https://github.com/carbon-design-system/carbon/blob/master/packages/icon-helpers/src/getAttributes.js#L15-L17 ckeditor/ckeditor5#668 (comment) It could easily not be needed anymore, but it did come up with our icons last year. |
it seems to be unnecessary now so we can probably remove it as well (ckeditor/ckeditor5#1053 ckeditor/ckeditor5-ui#529)? I didn't notice any blurriness when reviewing @tw15egan's PR on Firefox |
@emyarod nice, then yeah can 100% remove it upstream |
6718b01
to
2c8a97d
Compare
db027d8
to
bb28971
Compare
@asudoh @emyarod @joshblack updated the PR to simply remove adding the |
@tw15egan it seems like the preview for icons from netlify ran into an issue 🤔 I believe it's related to this line: https://github.com/carbon-design-system/carbon/blob/master/packages/icons/examples/preview/index.js#L203-L204 which was assuming |
28d27c9
to
83996be
Compare
@joshblack should be resolved now |
🔥 |
Closes #4718
Closes #4413
Issue 1 can be seen here: https://codesandbox.io/s/header-with-actions-and-nav-qre4k
For some reason,
will-change: transform
that is hardcoded on the SVG was causing issues on expansion in a few instances inUI-shell
Changelog
Changed
ChevronDown16
instead ofChevronDownGlyph
Removed
will-change
property on the chevron SVG'sTesting / Reviewing
Check the CodeSandbox, inspect the chevron SVG, and remove the
will-change
property. See how the dropdown works properly when this is removed.