Remove the `cpack` command alias #89

rpavlik · 2015-02-09T16:51:11Z

cpack is the command used by CMake to invoke its package generator. Not sure the polite way to resolve this.

And for reference, it also uses cmake and ctest.

(And apparently Microsoft is using CMake to build their open-source .NET on other platforms now...)

The text was updated successfully, but these errors were encountered:

ferventcoder · 2015-02-09T17:22:45Z

Aware of this. One reason we are moving away from the shorter ones (at least cpush and cpack).

Cpack as a shortcut to choco pack has been deprecated and will be removed in v1. Note this in the help menu.

* stable: (GH-417) Choco config command (maint) Config output skip by contains password (GH-416) Features should contain description (GH-88) Modify existing source (GH-71) Sources can have explicit priority order (maint) resharper team settings (maint) Case insensitive String.contains (maint) formatting (GH-89) Note cpack has been deprecated (GH-33) Allow Shutting off checksumming # Conflicts: # src/chocolatey/chocolatey.csproj # src/chocolatey/infrastructure.app/builders/ConfigurationBuilder.cs # src/chocolatey/infrastructure.app/services/ChocolateyConfigSettingsService.cs

dothebart · 2016-04-08T14:30:56Z

Chocolatey should either prefix its binary or setup the path environment in a way that it doesn't disturb the packages it installed.

ferventcoder · 2016-04-08T15:00:57Z

@dothebart Chocolatey itself does prefix the binary shortcuts with c (like cpack). So it already does this. This is the only known case where that presents an issue.

Or do you mean like choco pack?

solvingj · 2017-05-31T13:58:09Z

Just tried to use Cpack for Cmake on windows, chocolatey getting in the way. What's the status of this? Looks like a PR was merged 2 years ago?

ferventcoder · 2017-05-31T23:16:36Z

@solvingj Do you have a link to a PR?

ferventcoder · 2017-05-31T23:21:00Z

@solvingj If you are talking about e9dcb0c,

deprecation != removal - deprecations keep functionality but announce it is being removed in the future. HTH

dothebart · 2017-06-01T07:52:57Z

Maybe once the user installs cmake it could be clear, that he doesn't want a cpack alias and it could be removed then?

ferventcoder · 2017-06-01T14:08:14Z

If you install CMake through Chocolatey using the portable version, it will overwrite cpack. However any actions to install packages or outside of Chocolatey's control, it becomes hard to know when those kind of occurrences happen. It's probably best to ensure there is documentation in troubleshooting about this, but over that, it's unknown what we can do until cpack is removed. We must follow a transition (deprecation) in removing things.

dothebart · 2017-06-01T14:21:02Z

one sure thing is, that you usually would call the cmake - cpack with -G <packageformat> - maybe even inside of scrips. Unless you handle -G as a valid parameter in chocolateys cpack its a safe bet to search for cpack in the rest of the given paths and call that with $@ - or error out with a clear error message to the user that this is not cmake cpack which he probably desired to invoke, and how he can remove the unwanted cpack with del ...cpack.exe

ferventcoder · 2017-06-01T15:21:29Z

@dothebart you mean pass this on to a different cpack based on arguments. That is actually a really good idea!

ferventcoder · 2017-06-01T15:22:45Z

See #1317

native-api · 2019-10-21T00:12:16Z

Another option:

use dashed prefixes like Apt: choco-pack

solvingj · 2019-10-22T16:08:56Z

@ferventcoder an easy way to move forward on this (by that I mean, help all the people it annoys without breaking anyone) is to implement one or more environment variables which toggle the behavior.

CHOCO_ENABLE_ALIASES=True

or if you want to get more granular:

CHOCO_ENABLE_ALIAS_CPACK=True

If the value is False, you can choose to punt the command back to the shell so that CMake's cpack could pick it up, and if True (the default), you can actually handle it in chocolatey the way you do today.

You could also make it an install-time variable which prevents the aliases from ever being installed. As a user, I do not have a preference at this time.

native-api · 2019-10-23T04:50:11Z

Per #431 and https://github.com/chocolatey/choco/blob/master/docs/generated/CommandsReference.md#scripting--integration---best-practices--style-guide, the aliases are deprecated since 2015. So this can be used as an opportunity to remove them altogether.

ferventcoder · 2019-10-30T21:46:10Z

@native-api per my previous comments - deprecated is not removed. It's something you have to plan for and give folks plenty of time. Deprecated is a warning in the SHIM stating it is going to be removed as of version x - that hasn't been put in yet. So we won't be removing the shims yet. Note the removal is planned for v1 as per the milestone here.

There are known incompatibilities with this shim when other applications are installed on the machine, for example cmake. Since we are moving towards usage of a ubiquitous choco command, removing this shim makes a lot of sense.

This commit updates the installation/upgrading of the package to remove the cpack shim if they are signed with the expected authenticode signature thumbprint. The thumbprint being checked against in the thumbprint used in Chocolatey v0.12.1. The code added makes it easy to extend it when needed for removal of other shims as well.

There are known incompatibilities with this shim when other applications are installed on the machine, for example cmake. Since we are moving towards usage of a ubiquitous choco command, removing this shim makes a lot of sense.

This commit updates the installation/upgrading of the package to remove the cpack shim if they are signed with the expected authenticode signature thumbprint. The thumbprint being checked against in the thumbprint used in Chocolatey v0.12.1. The code added makes it easy to extend it when needed for removal of other shims as well.

There are known incompatibilities with this shim when other applications are installed on the machine, for example cmake. Since we are moving towards usage of a ubiquitous choco command, removing this shim makes a lot of sense.

This commit updates the installation/upgrading of the package to remove the cpack shim if they are signed with the expected authenticode signature thumbprint. The thumbprint being checked against in the thumbprint used in Chocolatey v0.12.1. The code added makes it easy to extend it when needed for removal of other shims as well.

There are known incompatibilities with this shim when other applications are installed on the machine, for example cmake. Since we are moving towards usage of a ubiquitous choco command, removing this shim makes a lot of sense.

This commit updates the installation/upgrading of the package to remove the cpack shim if they are signed with the expected authenticode signature thumbprint. The thumbprint being checked against in the thumbprint used in Chocolatey v0.12.1. The code added makes it easy to extend it when needed for removal of other shims as well.

This commit updates the installation/upgrading of the package to remove the cpack shim if they are signed with the an authenticode signature with the subject set to one of our previously used authenticode signatures. The code added makes it easy to extend it when needed for removal of other shims as well.

(#89) Remove cpack shim for choco pack

dothebart · 2022-03-14T13:34:10Z

Thanks for getting this finally resolved.

gep13 · 2022-03-14T13:38:19Z

@dothebart while this has been merged, it won't be live until the next release of Chocolatey, but it will go out in the next release 😄

* release/1.0.0: (65 commits) (version) v1.0.0 (#2443) Fix misspellings for profile text (#2468) Remove choco update command (#2468) Remove choco version command (#2602) Add 1.0.0 of shimgen and update shims (#89) Remove cpack shims on package upgrades (#89) Remove cpack shim for choco pack (maint) Update deprecation notice for config settings (build) Additional tweaks to version numbers (build) Add SolutionVersion.cs file to artifacts (docs) Update committers docs with correct/fixed links (build) Minor tweaks to build files (#2615) Reference CREDITS file for other licenses (build) Refactor Nuget Upload (build) Added missing Kotlin import (maint) Whitespace (#2614) Update 7zip / Shimgen licenses (#2614) Update project contributors (#2641) Minor tweaks to wording and formatting (#2462) Remove mention of alias for search comand ...

ferventcoder added 0 - _Triaging Improvement labels Feb 9, 2015

ferventcoder added 0 - Backlog and removed 0 - _Triaging labels Jun 30, 2015

ferventcoder modified the milestones: 1.x, 1.0.0 Jun 30, 2015

ferventcoder mentioned this issue Sep 21, 2015

MOVED - Deprecate aliases like “cpack” chocolatey-archive/chocolatey#431

Closed

ferventcoder changed the title ~~Name collision: cpack~~ Remove some of the command aliases, like cpack Sep 21, 2015

ferventcoder added a commit that referenced this issue Sep 21, 2015

(GH-89) Note cpack has been deprecated

e9dcb0c

Cpack as a shortcut to choco pack has been deprecated and will be removed in v1. Note this in the help menu.

ferventcoder mentioned this issue Jun 1, 2017

Make cpack work with both Chocolatey and CMake, depending on arguments #1317

Closed

native-api mentioned this issue Oct 23, 2019

(GH-89) Rename shims to an apt-style prefix #1946

Closed

native-api mentioned this issue Oct 23, 2019

(GH-89) Remove shims #1947

Closed

al-cheb mentioned this issue Apr 1, 2020

Remove choco alias cpack.exe that conflicts with CMake cpack actions/runner-images#651

Merged

4 tasks

gep13 self-assigned this Jan 22, 2022

gep13 added 3 - Review and removed 0 - Backlog labels Jan 22, 2022

corbob added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Mar 1, 2022

gep13 closed this as completed in #2551 Mar 14, 2022

gep13 added a commit that referenced this issue Mar 14, 2022

Merge pull request #2551 from gep13/issue-89

9a61954

(#89) Remove cpack shim for choco pack

gep13 added 4 - Done and removed 3 - Review labels Mar 14, 2022

corbob added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Mar 14, 2022

gep13 added 5 - Released and removed 4 - Done labels Mar 21, 2022

gtritchie mentioned this issue Mar 21, 2022

build fix, accomodate choco's removal of cpack alias rstudio/rstudio#10813

Merged

HofmeisterAn mentioned this issue Mar 24, 2022

[Windows] CPack command alias is not part of Choco anymore actions/runner-images#5278

Merged

4 tasks

gep13 mentioned this issue Mar 20, 2023

Remove deprecated Chocolatey shims (chocolatey, cinst, clist, cpush, cuninst, cup) #2642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the `cpack` command alias #89

Remove the `cpack` command alias #89

rpavlik commented Feb 9, 2015

ferventcoder commented Feb 9, 2015

dothebart commented Apr 8, 2016

ferventcoder commented Apr 8, 2016 •

edited

Loading

solvingj commented May 31, 2017

ferventcoder commented May 31, 2017

ferventcoder commented May 31, 2017

dothebart commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

dothebart commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

native-api commented Oct 21, 2019 •

edited

Loading

solvingj commented Oct 22, 2019 •

edited

Loading

native-api commented Oct 23, 2019

ferventcoder commented Oct 30, 2019

dothebart commented Mar 14, 2022

gep13 commented Mar 14, 2022

Remove the cpack command alias #89

Remove the cpack command alias #89

Comments

rpavlik commented Feb 9, 2015

ferventcoder commented Feb 9, 2015

dothebart commented Apr 8, 2016

ferventcoder commented Apr 8, 2016 • edited Loading

solvingj commented May 31, 2017

ferventcoder commented May 31, 2017

ferventcoder commented May 31, 2017

dothebart commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

dothebart commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

ferventcoder commented Jun 1, 2017

native-api commented Oct 21, 2019 • edited Loading

solvingj commented Oct 22, 2019 • edited Loading

native-api commented Oct 23, 2019

ferventcoder commented Oct 30, 2019

dothebart commented Mar 14, 2022

gep13 commented Mar 14, 2022

Remove the `cpack` command alias #89

Remove the `cpack` command alias #89

ferventcoder commented Apr 8, 2016 •

edited

Loading

native-api commented Oct 21, 2019 •

edited

Loading

solvingj commented Oct 22, 2019 •

edited

Loading