(GH-89) Remove shims #1947
Closed
(GH-89) Remove shims #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shims were deprecated since 26a98f8. Since `cpack` proved to conflict with CMake, this is an opportunity to pull the plug on this feature.
|
Travis failure unrelated, caused by #1020 |
|
Travis failure unrelated, caused by #1020 and https://changelog.travis-ci.com/xenial-as-the-default-build-environment-99476 |
ferventcoder
added
invalid
|
Hi @native-api, Just a note that #89 is linked to v1, not where we currently are at. There is work to be done in the interim where we need to tell folks those things are being removed. If you want to look at providing a warning when those are used, I'm all for that. However a removal or rename is not going to be considered at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shims were deprecated since 26a98f8.
Since
cpackproved to conflict with CMake, this is an opportunityto pull the plug on this feature.
Fixes #89.