Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference CREDITS.md in project NOTICE file #2615

Closed
gep13 opened this issue Mar 4, 2022 · 0 comments · Fixed by #2645
Closed

Reference CREDITS.md in project NOTICE file #2615

gep13 opened this issue Mar 4, 2022 · 0 comments · Fixed by #2645
Assignees
@pauby
Labels
5 - Released Documentation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone
1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 4, 2022 •
edited by pauby
Loading

What You Are Seeing?

The NOTICE file in the root of the project does not reference the other licenses that the project uses. These are held in the docs/legal/CREDITS.md file.

What is Expected?

The NOTICE file should be make reference to the other licenses in CREDITS.md file.

How Did You Get This To Happen? (Steps to Reproduce)

N/A.

Output Log

N/A.
@gep13 gep13 added this to the 1.0.0 milestone Mar 4, 2022
pauby added a commit to pauby/choco that referenced this issue Mar 10, 2022
@pauby
(chocolatey#2615) Reference CREDITS file for other licenses
d4f753a
@pauby pauby mentioned this issue Mar 11, 2022
Merged
AdmiringWorm pushed a commit to pauby/choco that referenced this issue Mar 11, 2022
@pauby @AdmiringWorm
(chocolatey#2615) Reference CREDITS file for other licenses
d4a504c
@gep13 gep13 added NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. and removed NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. labels Mar 15, 2022
gep13 added a commit that referenced this issue Mar 18, 2022
@gep13
Merge branch 'release/1.0.0'
5c9117a 
* release/1.0.0: (65 commits)
  (version) v1.0.0
  (#2443) Fix misspellings for profile text
  (#2468) Remove choco update command
  (#2468) Remove choco version command
  (#2602) Add 1.0.0 of shimgen and update shims
  (#89) Remove cpack shims on package upgrades
  (#89) Remove cpack shim for choco pack
  (maint) Update deprecation notice for config settings
  (build) Additional tweaks to version numbers
  (build) Add SolutionVersion.cs file to artifacts
  (docs) Update committers docs with correct/fixed links
  (build) Minor tweaks to build files
  (#2615) Reference CREDITS file for other licenses
  (build) Refactor Nuget Upload
  (build) Added missing Kotlin import
  (maint) Whitespace
  (#2614) Update 7zip / Shimgen licenses
  (#2614) Update project  contributors
  (#2641) Minor tweaks to wording and formatting
  (#2462) Remove mention of alias for search comand
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauby pauby

Labels
5 - Released Documentation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

(#2615/#2549) Reference CREDITS file for other licenses pauby/choco
3 participants
@gep13 @AdmiringWorm @pauby