Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Chocolatey commands and shims #2468

Closed
pauby opened this issue Nov 23, 2021 · 2 comments · Fixed by #2550
Closed

Remove deprecated Chocolatey commands and shims #2468

pauby opened this issue Nov 23, 2021 · 2 comments · Fixed by #2550
Assignees
@gep13
Labels
5 - Released Breaking Change IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented
Milestone
1.0.0

Comments

@pauby
Copy link
Member

pauby commented Nov 23, 2021 •
edited by gep13
Loading

The following commands have been marked as deprecated and should be removed in v1.0.0:

As well as removing the Chocolatey commands, i.e. choco update and choco version, we also need to make sure to remove the shim(s) that are installed.

There is a shim cver that executes choco version and needs to be removed.

An update to the chocolateyInstall.ps1 will be required to ensure that this is removed after successful installation of 1.0.0.

NOTE: The cup is not being removed. This correctly points at choco upgrade and will be removed in 2.0.0.
@pauby pauby added this to the 1.0.0 milestone Nov 23, 2021
@pauby pauby changed the title Remove Chocolatey commands Remove deprecated Chocolatey commands Nov 23, 2021
@pauby pauby mentioned this issue Nov 23, 2021
Open
@gep13
Copy link
Member

gep13 commented Jan 19, 2022

This will also mean the shim for cver needs to go away as well.

gep13 added a commit to gep13/choco that referenced this issue Jan 22, 2022
@gep13
(chocolatey#2468) Remove choco version command
4622a8c 
This command is no longer required, and has been replaced by either the
choco list or the choco upgrade --noop commands depending on whether you
are attempting to get locally installed items, or checking to see what
upgrades are availble.

In addition, the cver shim has also been removed.
gep13 added a commit to gep13/choco that referenced this issue Jan 22, 2022
@gep13
(chocolatey#2468) Remove choco update command
fc97f5d 
This command has been replaced by the choco upgrade command. At some
point, the choco update command will be re-instated, with the purpose of
updating the local package index of packages.
@gep13 gep13 mentioned this issue Jan 22, 2022
Merged
@gep13 gep13 self-assigned this Jan 22, 2022
@gep13 gep13 added the Requires Upstream Change Requires changes to a different location once issue is fixed or implemented label Jan 22, 2022
@gep13
Copy link
Member

gep13 commented Jan 22, 2022

There will need to be changes in chocolatey.extension as well, as these commands are overridden there.

@gep13 gep13 mentioned this issue Feb 4, 2022
Closed
@gep13 gep13 changed the title Remove deprecated Chocolatey commands Remove deprecated Chocolatey commands and shims Feb 4, 2022
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Feb 5, 2022
Closed
@corbob corbob added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Mar 1, 2022
@sync-by-unito sync-by-unito bot mentioned this issue Mar 9, 2022
Closed
3 tasks
gep13 added a commit to gep13/choco that referenced this issue Mar 11, 2022
@gep13
(chocolatey#2468) Remove choco version command
01208b0 
This command is no longer required, and has been replaced by either the
choco list or the choco upgrade --noop commands depending on whether you
are attempting to get locally installed items, or checking to see what
upgrades are available.

In addition, the cver shim has also been removed.
gep13 added a commit to gep13/choco that referenced this issue Mar 11, 2022
@gep13
(chocolatey#2468) Remove choco update command
967e0d0 
This command has been replaced by the choco upgrade command. At some
point, the choco update command will be re-instated, with the purpose of
updating the local package index of packages.
gep13 added a commit to gep13/choco that referenced this issue Mar 14, 2022
@gep13
(chocolatey#2468) Remove choco version command
2c32292 
This command is no longer required, and has been replaced by either the
choco list or the choco upgrade --noop commands depending on whether you
are attempting to get locally installed items, or checking to see what
upgrades are available.

In addition, the cver shim has also been removed.
gep13 added a commit to gep13/choco that referenced this issue Mar 14, 2022
@gep13
(chocolatey#2468) Remove choco update command
590a207 
This command has been replaced by the choco upgrade command. At some
point, the choco update command will be re-instated, with the purpose of
updating the local package index of packages.
@gep13 gep13 added 4 - Done and removed 3 - Review labels Mar 14, 2022
@corbob corbob added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Mar 14, 2022
gep13 added a commit that referenced this issue Mar 18, 2022
@gep13
Merge branch 'release/1.0.0'
5c9117a 
* release/1.0.0: (65 commits)
  (version) v1.0.0
  (#2443) Fix misspellings for profile text
  (#2468) Remove choco update command
  (#2468) Remove choco version command
  (#2602) Add 1.0.0 of shimgen and update shims
  (#89) Remove cpack shims on package upgrades
  (#89) Remove cpack shim for choco pack
  (maint) Update deprecation notice for config settings
  (build) Additional tweaks to version numbers
  (build) Add SolutionVersion.cs file to artifacts
  (docs) Update committers docs with correct/fixed links
  (build) Minor tweaks to build files
  (#2615) Reference CREDITS file for other licenses
  (build) Refactor Nuget Upload
  (build) Added missing Kotlin import
  (maint) Whitespace
  (#2614) Update 7zip / Shimgen licenses
  (#2614) Update project  contributors
  (#2641) Minor tweaks to wording and formatting
  (#2462) Remove mention of alias for search comand
  ...
@gep13 gep13 mentioned this issue Mar 24, 2022
Closed
@Windos Windos mentioned this issue Apr 7, 2022
Open
@gep13 gep13 mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Breaking Change IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

(#2468) Remove deprecated Chocolatey commands gep13/choco
3 participants
@gep13 @pauby @corbob