Reseal upgrade command and remove virtuals

[TheCakeIsNaOH]

As noted in a todo comment in this file: https://github.com/chocolatey/choco/blob/develop/src/chocolatey/infrastructure.app/commands/ChocolateyUpgradeCommand.cs

It was added in this commit for more context: 6b20a17

If I am parsing it correctly, this class can be resealed once the version command goes away. #2468

[gep13]

@TheCakeIsNaOH said...
If I am parsing it correctly, this class can be resealed once the version command goes away.

Yes, I am reading this the same way, and I am wondering whether we should include this work alongside the deprecation of those commands.

[gep13]

@pauby I have added this to the v1.0.0 milestone so that we can discuss this during the week.

[gep13]

@TheCakeIsNaOH based on a chat with @AdmiringWorm I don't think that we can do this work, as this would prevent things from being overridable in the Chocolatey Licensed Extension. I suspect that we will just close out this issue, and remove the comment in the code, but leave this one with me.

[AdmiringWorm]

As the commands can not be resealed due to how we require the commands to be overridable for us to use them in Chocolatey Licensed Extension, this issue won't be fulfilled.

After talking with @gep13 about this issue, I have removed the TODO comment in #2609 and will be closing this issue now.