Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Remove todo comment about resealing commands #2609

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

AdmiringWorm
Copy link
Member

This pull request removes the todo comment about resealing the upgrade
command.
This is removed due to our usage in Chocolatey Licensed Extension
means that we can not reseal the command without breaking
the Licensed Extension, or doing major rework of the Extension
to allow it to happen.

This commit removes the todo comment about resealing the upgrade
command.
This is removed due to our usage in Chocolatey Licensed Extension
means that we can not reseal the command without breaking
the Licensed Extension, or doing major rework of the Extension
to allow it to happen.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 9fa89d3 into chocolatey:develop Mar 3, 2022
@gep13
Copy link
Member

gep13 commented Mar 3, 2022

@AdmiringWorm thanks for getting this fixed up!

@AdmiringWorm AdmiringWorm deleted the remove-invalid-todo branch March 3, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants