Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the --pin option on the install and upgrade commands #798

Closed
CWempe opened this issue Jun 14, 2016 · 4 comments · Fixed by #2463
Closed

Add support for the --pin option on the install and upgrade commands #798

CWempe opened this issue Jun 14, 2016 · 4 comments · Fixed by #2463
Assignees
Labels
5 - Released Documentation Hacktoberfest Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented Up For Grabs
Milestone

Comments

@CWempe
Copy link

CWempe commented Jun 14, 2016

I just found out about chocolately and I think this is a great project!

Reading the issues here, I thought of a feature request.

I think it would be great if you could "pin" a package directly during (after) the installation.

Instead of

choco install googlechrome
choco pin googlechrome

something like this
choco install googlechrome --pin

This would especialy come in handy when installing a list of packages via package.conf.

    <?xml version="1.0" encoding="utf-8"?>
    <packages>
      <package id="googlechrome" pin="true" />
    </packages>

Then again this might be obsolet (in some cases) when #242 gets implemented.

@ferventcoder
Copy link
Member

@CWempe I believe this has been discussed before and it's a pretty great idea! I'm surprised that there wasn't already an existing ticket (I searched), perhaps from the prior discussions one was not created.

@ferventcoder ferventcoder changed the title pin package during installation install - pin package during installation Sep 26, 2018
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 18, 2021
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 18, 2021
Add specs for pin parameter for the install/upgrade commands
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 18, 2021
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 18, 2021
Add specs for pin parameter for the install/upgrade commands
JeroenBos added a commit to JeroenBos/JBSnorro.LayoutEngine that referenced this issue Nov 21, 2021
@gep13 gep13 added 3 - Review Requires Upstream Change Requires changes to a different location once issue is fixed or implemented and removed 0 - Backlog labels Dec 23, 2021
@gep13
Copy link
Member

gep13 commented Dec 23, 2021

Any change in this area will require an upstream change in the chocolatey.extension to ensure that any and all new logic is respected there.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Dec 24, 2021
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Dec 24, 2021
Add specs for pin parameter for the install/upgrade commands
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 17, 2022
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 17, 2022
Add specs for pin parameter for the install/upgrade commands
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 17, 2022
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Aug 12, 2022
@gep13 gep13 added 4 - Done and removed 3 - Review labels Aug 13, 2022
@choco-bot choco-bot added Documentation ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Aug 24, 2022
@gep13
Copy link
Member

gep13 commented Aug 25, 2022

A follow up spike task has been created to confirm that this functionality continues to work as expected when the Chocolatey Licensed Extension is installed: https://gitlab.com/chocolatey/collaborators/choco-licensed/-/issues/631

corbob added a commit to corbob/choco that referenced this issue Sep 21, 2022
Add tests that we are pinning packages when during upgrade and install
when done with the `--pin` parameter.
@corbob corbob added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Sep 21, 2022
@corbob corbob changed the title install - pin package during installation Add support for the --pin option on the install and upgrade commands Sep 23, 2022
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 23, 2022
corbob added a commit to corbob/choco that referenced this issue Sep 23, 2022
Add tests that we are pinning packages when during upgrade and install
when done with the `--pin` parameter.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 23, 2022
corbob added a commit to corbob/choco that referenced this issue Sep 24, 2022
Add tests that we are pinning packages when during upgrade and install
when done with the `--pin` parameter.
corbob added a commit to corbob/choco that referenced this issue Sep 24, 2022
Add tests that we are pinning packages when during upgrade and install
when done with the `--pin` parameter.
corbob added a commit to corbob/choco that referenced this issue Sep 26, 2022
Add tests that we are pinning packages when during upgrade and install
when done with the `--pin` parameter.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Oct 19, 2022
This commit adds the `--pin` option to the list of available
options in the table completion.
The pin option was added to the install and upgrade command in this
release.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Oct 19, 2022
This commit adds the `--pin` option to the list of available
options in the table completion.
The pin option was added to the install and upgrade command in this
release.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Oct 19, 2022
* release/1.2.0: (374 commits)
  (maint) Add incoming arguments available in Licensed Extension
  (chocolatey#798) Add missing pin option in tab completion
  (chocolatey#2860) Add e2e tests for new PS cmdlet
  (maint) Fix Chocolatey path in docs generation
  (chocolatey#2860) Add new PS helper to get maintainer specific paths
  (chocolatey#2816) Update to latest Chocolatey NuGet.Core
  (chocolatey#2693) Re-add old resolve or load method
  (chocolatey#886) Update packages.config install logging
  (chocolatey#1185) Always pass in hook scripts event if empty
  Update tests/chocolatey-tests/commands/choco-outdated.Tests.ps1
  (chocolatey#2801) Pin Chocolatey packages for outdated tests
  (chocolatey#886) Use specific strings for configurations
  (chocolatey#886) Add Pester tests for packages.config
  (chocolatey#886) Debug log Package configuration
  (chocolatey#1185) Be explicit with expected exit codes
  (maint) Pester test directory structure shuffle
  (chocolatey#1185) Add tests for hook scripts
  (maint) Minor formatting change
  (chocolatey#798) Add tests for pinning package on install
  (chocolatey#2787) Restore Chocolatey snapshot before sxs
  ...
@AdmiringWorm
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

AdmiringWorm added a commit that referenced this issue Oct 20, 2022
* master:
  (maint) Add incoming arguments available in Licensed Extension
  (#798) Add missing pin option in tab completion
  (#2860) Add e2e tests for new PS cmdlet
  (maint) Fix Chocolatey path in docs generation
  (#2860) Add new PS helper to get maintainer specific paths
  (#2816) Update to latest Chocolatey NuGet.Core
  (#2693) Re-add old resolve or load method
  (#886) Update packages.config install logging
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Dec 22, 2022
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Dec 23, 2022
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 7, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment