(#798) Add pin-version parameter for choco install command to execute choco pin at the end #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…co pin for the given package.
|
The broken Travis build does not seem to be a problem of this PR but generally broken in master now. |
|
|
gep13
changed the title
gep13
changed the title
7 tasks
|
@bergmeister please accept my apologies for the lack of reply on this PR. We should have done more with you to improve your experience here. This is something that we are working on, and something we aim to do better in the future. As it stands though, the work in this PR has been superseded by this PR: #2463 therefore, I am going to close out this PR. Thank you again for your contribution, and I hope that this doesn't prevent you from contributing in the future! |
|
No worries, I am glad we will get the functionality at least, which matters most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
This is the first minimum viable implementation. I haven't tested it yet as I'd like to see if it would pass the build validation and more importantly I would like to get early feedback on the implementation (as to whether the high level approach is OK) before writing more complex tests with which I'd appreciate help