(#798) Add parameter to install and upgrade commands to pin after install #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am aware that this is a duplicate PR to #1915, I just think that this is a cleaner implementation to add the pin file directly via @bergmeister feel free to use my code to update your PR if you want and I can close this PR. It was easier to throw this PR together rather than trying to describe what I am suggesting in writing. |
7 tasks
TheCakeIsNaOH
force-pushed
the
install-pin
branch
from
028326a to
9f37327
Compare
TheCakeIsNaOH
force-pushed
the
install-pin
branch
from
9f37327 to
30112e8
Compare
TheCakeIsNaOH
force-pushed
the
install-pin
branch
from
30112e8 to
8d5263a
Compare
TheCakeIsNaOH
force-pushed
the
install-pin
branch
from
8d5263a to
66264f0
Compare
TheCakeIsNaOH
force-pushed
the
install-pin
branch
from
66264f0 to
0f19b70
Compare
TheCakeIsNaOH
force-pushed
the
install-pin
branch
2 times, most recently
from
375a20c to
78287ad
Compare
Make indenting consistent for parameters in install and upgrade commands.
This adds a parameter to pin packages after install or upgrade. It re-uses the code in save_package_information to create the pin file.
Add specs for pin parameter for the install/upgrade commands
This adds the PinPackage element to the definition of the packages.config format. This allows the pin-package argument to be used via a config file.
|
@TheCakeIsNaOH thanks for pulling all this together! I made a slight change in the PR to mark the new option as being available in 1.2.0 rather than 1.1.0. I will get this merged in, assuming that the CI builds pass. |
A mistake was made in previous commit, where property name was changed to use a more consistent version, however, the wrong property name was changed, and this wasn't tested before pushing up the commit.
|
The failing Ubuntu build here is a known issue, so going to move forward with getting this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds a parameter to pin packages after install or upgrade.
It re-uses the code in save_package_information to create the pin file.
Motivation and Context
See #798
Testing
wgetwith--pin, checked that it was pinned withchoco pin listwgetwithout--pin, checked that it was not pinned withchoco pin listwgetwith--pin, checked that it was pinned withchoco pin listwgetwithout--pin, checked that it was not pinned withchoco pin listCreate this
packages.configfile:Install via that file and then check that wget is pinned with
choco pin listChange Types Made
Related Issue
Fixes #798
Change Checklist