Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate side-by-side installs #2787

Closed
pauby opened this issue Aug 10, 2022 · 8 comments · Fixed by #2813
Closed

Deprecate side-by-side installs #2787

pauby opened this issue Aug 10, 2022 · 8 comments · Fixed by #2813
Assignees
@AdmiringWorm
Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented Task
Milestone
1.2.0

Comments

@pauby
Copy link
Member

pauby commented Aug 10, 2022 •
edited
Loading

Is Your Feature Request Related To A Problem? Please describe.

Side-by-side installs are planned to be deprecated in a future (potentially version 2.0) of Chocolatey CLI. We need to ensure we properly deprecate this in the collection.

Note that before this is deprecated, we will have documentation describing the options available to continue to have similar functionality.

Describe The Solution. Why is it needed?

Side-by-side installs are being deprecated.

Additional Context.

Before this is deprecated, we will have documentation describing the options available to continue to have similar functionality.

Related Issues

None.
@pauby pauby added this to the 1.2.0 milestone Aug 10, 2022
This was referenced Aug 10, 2022
Closed
Closed
@gep13 gep13 mentioned this issue Aug 11, 2022
Closed
@AdmiringWorm AdmiringWorm self-assigned this Sep 13, 2022
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 14, 2022
@AdmiringWorm
(chocolatey#2787) Deprecate side-by-side installations
c3de6e7 
This commit makes the necessary changes to deprecate
side by side installations in the Chocolatey CLI codebase as well
as warn the users about any installations for side-by-side.
Including if the user have side-by-side installations already
installed on their system.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 14, 2022
@AdmiringWorm
(chocolatey#2787) Add tests for side-by-side deprecation
48c90e0
@AdmiringWorm AdmiringWorm mentioned this issue Sep 15, 2022
Merged
9 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 15, 2022
@AdmiringWorm
(chocolatey#2787) Add tests for side-by-side deprecation
9e4c4bc
@AdmiringWorm AdmiringWorm added 3 - Review IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed 2 - Working labels Sep 15, 2022
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 15, 2022
@AdmiringWorm
(chocolatey#2787) Deprecate side-by-side installations
09b2473 
This commit makes the necessary changes to deprecate
side by side installations in the Chocolatey CLI codebase as well
as warn the users about any installations for side-by-side.
Including if the user have side-by-side installations already
installed on their system.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 15, 2022
@AdmiringWorm
(chocolatey#2787) Add tests for side-by-side deprecation
38030f9
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 16, 2022
@AdmiringWorm
(chocolatey#2787) Deprecate side-by-side installations
d6dbdfd 
This commit makes the necessary changes to deprecate
side by side installations in the Chocolatey CLI codebase as well
as warn the users about any installations for side-by-side.
Including if the user have side-by-side installations already
installed on their system.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Sep 16, 2022
@AdmiringWorm
(chocolatey#2787) Add tests for side-by-side deprecation
fce126a
corbob added a commit that referenced this issue Sep 20, 2022
@corbob
Merge pull request #2813 from AdmiringWorm/a2787-Deprecate-side-by-si…
f44f65f 
…de-installs

(#2787) Deprecate side by side installations
corbob added a commit to corbob/choco that referenced this issue Sep 21, 2022
@corbob
(chocolatey#2787) Restore Chocolatey snapshot before sxs
5ff2f85 
The info tests enable a proxy that prevents the side by side tests from
actually working correctly. This restores the Snapshot so we have a
fresh Chocolatey installation to test against.
@corbob corbob mentioned this issue Sep 21, 2022
Merged
9 tasks
@corbob corbob added the Requires Upstream Change Requires changes to a different location once issue is fixed or implemented label Sep 22, 2022
@corbob
Copy link
Member

corbob commented Sep 23, 2022

The Licensed Extension extends the Info command. Our current tests expect it to output a deprecation message. We will want to assess if we duplicate that message into the Licensed Extension, or update the test to be FOSSOnly. Added the Upstream Change label for tracking, and will discuss more at planning meeting.

corbob added a commit to corbob/choco that referenced this issue Sep 23, 2022
@corbob
(chocolatey#2787) Restore Chocolatey snapshot before sxs
4a488f6 
The info tests enable a proxy that prevents the side by side tests from
actually working correctly. This restores the Snapshot so we have a
fresh Chocolatey installation to test against.
corbob added a commit to corbob/choco that referenced this issue Sep 24, 2022
@corbob
(chocolatey#2787) Restore Chocolatey snapshot before sxs
a217b1c 
The info tests enable a proxy that prevents the side by side tests from
actually working correctly. This restores the Snapshot so we have a
fresh Chocolatey installation to test against.
corbob added a commit to corbob/choco that referenced this issue Sep 24, 2022
@corbob
(chocolatey#2787) Restore Chocolatey snapshot before sxs
2ad825d 
The info tests enable a proxy that prevents the side by side tests from
actually working correctly. This restores the Snapshot so we have a
fresh Chocolatey installation to test against.
corbob added a commit to corbob/choco that referenced this issue Sep 26, 2022
@corbob
(chocolatey#2787) Restore Chocolatey snapshot before sxs
8c1e1b0 
The info tests enable a proxy that prevents the side by side tests from
actually working correctly. This restores the Snapshot so we have a
fresh Chocolatey installation to test against.
@pauby pauby mentioned this issue Oct 19, 2022
Merged
7 tasks
@pauby pauby reopened this Oct 19, 2022
@pauby
Copy link
Member Author

pauby commented Oct 19, 2022 •
edited
Loading

This is being reopened as we need to pickup this task:

  • Before this is deprecated, we will have documentation describing the options available to continue to have similar functionality.

What was needed here was documentation that explained the alternative to side-by-side installs and specifically why it needs done. This was envisaged being a page in the docs.

AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Oct 19, 2022
@AdmiringWorm
Merge branch 'release/1.2.0'
edde979 
* release/1.2.0: (374 commits)
  (maint) Add incoming arguments available in Licensed Extension
  (chocolatey#798) Add missing pin option in tab completion
  (chocolatey#2860) Add e2e tests for new PS cmdlet
  (maint) Fix Chocolatey path in docs generation
  (chocolatey#2860) Add new PS helper to get maintainer specific paths
  (chocolatey#2816) Update to latest Chocolatey NuGet.Core
  (chocolatey#2693) Re-add old resolve or load method
  (chocolatey#886) Update packages.config install logging
  (chocolatey#1185) Always pass in hook scripts event if empty
  Update tests/chocolatey-tests/commands/choco-outdated.Tests.ps1
  (chocolatey#2801) Pin Chocolatey packages for outdated tests
  (chocolatey#886) Use specific strings for configurations
  (chocolatey#886) Add Pester tests for packages.config
  (chocolatey#886) Debug log Package configuration
  (chocolatey#1185) Be explicit with expected exit codes
  (maint) Pester test directory structure shuffle
  (chocolatey#1185) Add tests for hook scripts
  (maint) Minor formatting change
  (chocolatey#798) Add tests for pinning package on install
  (chocolatey#2787) Restore Chocolatey snapshot before sxs
  ...
@AdmiringWorm
Copy link
Member

@pauby I have created an issue on the docs repository to track the progress of this here: chocolatey/docs#581

@AdmiringWorm
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@thoscut
Copy link

thoscut commented Oct 26, 2022

I miss any info about why this feature needs to be removed beside planned to be deprecated, which from our company's perspective is a very unfortunate decision.
It would also have been a good idea to first create some docu about the deprecation message and the background before introducing it and letting people google for the message to find this issue, which doesn't contain helpful information. See e.g. ansible, usually/often there's a link to further docs on the message.

@pauby
Copy link
Member Author

pauby commented Oct 26, 2022

@thoscut The reason this is being removed is that it never worked the way it was intended to, caused us no end of support issues for a very small number of customers who used it.

The intention was to create the document before the release so it was available. That was unfortunately missed and is on me.

@viceice
Copy link

viceice commented Oct 28, 2022

I don't see any docs for fixing that notice

KB2533623 2.0.0

KB2919355 has been installed as a side by side installation.
Side by side installations are deprecated and is pending removal in v2.0.0.
KB2919355 1.0.20160915

KB2919442 has been installed as a side by side installation.
Side by side installations are deprecated and is pending removal in v2.0.0.
KB2919442 1.0.20160915

KB2999226 has been installed as a side by side installation.
Side by side installations are deprecated and is pending removal in v2.0.0.
KB2999226 1.0.20181019

KB3033929 has been installed as a side by side installation.
Side by side installations are deprecated and is pending removal in v2.0.0.
KB3033929 1.0.5

KB3035131 has been installed as a side by side installation.
Side by side installations are deprecated and is pending removal in v2.0.0.
KB3035131 1.0.3
KB3063858 1.0.0
KB3118401 1.0.5

How can i resolve this?

@pauby
Copy link
Member Author

pauby commented Oct 28, 2022

@viceice This issue is closed. Can you raise a separate issue for this? I'm assuming you didn't install those KB packages as side-by-side installs.

I'm going to lock this issue now to prevent comments that would be missed by the team.

@chocolatey chocolatey locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Requires Upstream Change Requires changes to a different location once issue is fixed or implemented Task
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

(#2787) Deprecate side by side installations AdmiringWorm/choco
5 participants
@AdmiringWorm @thoscut @viceice @pauby @corbob