-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle disconnection according to the dev workspace status #163
feat: Handle disconnection according to the dev workspace status #163
Conversation
Signed-off-by: Roman Nikitenko <[email protected]>
…stener automatically Signed-off-by: Roman Nikitenko <[email protected]>
19703f6
to
3e76287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested different use cases - everything works as described 👍
Thanks for updating the rebase rules.
Build 3.5 :: code_3.x/290: Console, Changes, Git Data |
Build 3.5 :: sync-to-downstream_3.x/2025: Console, Changes, Git Data |
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
Handle disconnection according to the dev workspace status:
Within testing I detected the following unusual use case:
I've added some logic to propose reloading the window for such use case - it fixes the disconnection. See the behaviour on the video.
reload_window.mp4
What issues does this PR fix?
eclipse-che/che#21610
How to test this PR?
It's possible to change the corresponding properties to test use cases related to timeouts:
See screenshot here
Run timeout
checluster.spec.devEnvironments.secondsOfRunBeforeIdling
) to 120, for example.Inactivity timeout
checluster.spec.devEnvironments.secondsOfInactivityBeforeIdling
) to 100, for example.An error
I tested the use case using minikube:
minikube ssh
=>docker ps
VS Code
and stop it, like:docker stop d9bd0222b513
Workspace is not running
The use case is related to the any case when
You can just stop a workspace using dashboard to test it.