Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to reconnect dialog sometimes appears even though workspace is still running #22287

Closed
dkwon17 opened this issue Jun 13, 2023 · 10 comments
Closed

Attempting to reconnect dialog sometimes appears even though workspace is still running #22287

dkwon17 opened this issue Jun 13, 2023 · 10 comments
Labels
area/dogfooding Using Eclispe Che to code, test and build Eclipse Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system. sprint/next team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Jun 13, 2023

Describe the bug

When working on my workspace try-in-web-ide-4u7r in the dogfooding cluster, sometimes when I would take a 20min break from coding, when I return to the editor, I was greeted with this dialog a few times:

image

This appeared even though my workspace (try-in-web-ide-4u7r) was still running:
image

As a workaround, IIRC refreshing the editor fixed the issue.

Che version

next (development version)

Steps to reproduce

Unfortunately I don't have steps to reproduce this behaviour, it happened to me maybe once every two days.

Expected behavior

The dialog should not appear.

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

macOS, other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response
@dkwon17 dkwon17 added kind/bug Outline of a bug - must adhere to the bug report template. dogfooding area/dogfooding Using Eclispe Che to code, test and build Eclipse Che labels Jun 13, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 13, 2023
@dkwon17 dkwon17 added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 13, 2023
@ibuziuk
Copy link
Member

ibuziuk commented Jun 28, 2023

@l0rd @azatsarynnyy folks, maybe this is smth you can investigate in the next sprint?

@ibuziuk ibuziuk added the team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. label Jun 28, 2023
@azatsarynnyy
Copy link
Member

It looks like #21610 became relevant again. As there're no Che-specific dialogs anymore that were introduced in che-incubator/che-code#163

@azatsarynnyy azatsarynnyy mentioned this issue Jun 28, 2023
Closed
@RomanNikitenko
Copy link
Member

maybe our patch was just rewritten by VS Code changes...

@azatsarynnyy
Copy link
Member

maybe our patch was just rewritten by VS Code changes...

most likely

@RomanNikitenko
Copy link
Member

If so - the solution doesn't require much effort

@l0rd l0rd moved this to 📅 Planned in Eclipse Che Team B Backlog Jun 28, 2023
@RomanNikitenko
Copy link
Member

btw, one of the screenshots displays a warning that WebSocket connections are failing.
so, maybe @dkwon17 has faced a problem when VS Code really loses WebSocket connection and tries to reconnect.
yes - the workspace is still running, but VS Code has lost the connection...

what behaviour would be better for such use case?
just propose user to refresh the page without attempt to reconnect?

@l0rd l0rd moved this from 📅 Planned to 📋 Backlog in Eclipse Che Team B Backlog Sep 6, 2023
@azatsarynnyy
Copy link
Member

I suggest postponing it until #22352 is fixed. I faced the current issue a few times and each time I saw that Dashboard issue.

@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Mar 8, 2024

/remove-lifecycle stale

@che-bot che-bot closed this as completed Mar 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog (not in current Sprint) to ✅ Done in Eclipse Che Team B Backlog Mar 15, 2024
@dkwon17 dkwon17 reopened this Mar 15, 2024
@dkwon17 dkwon17 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2024
@ibuziuk ibuziuk moved this from ✅ Done to 📅 Planned for this Sprint in Eclipse Che Team B Backlog Apr 3, 2024
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2024
@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dogfooding Using Eclispe Che to code, test and build Eclipse Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system. sprint/next team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dmytro-ndp @ibuziuk @azatsarynnyy @RomanNikitenko @che-bot @dkwon17