Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle idling in VS Code correctly instead of attempting to reconnect in x seconds #21610

Closed
Tracked by #21823 ...
l0rd opened this issue Aug 4, 2022 · 5 comments
Closed
Tracked by #21823 ...
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 4, 2022

Is your enhancement related to a problem? Please describe

Today if a VS Code workspace is idled the users sees a connection error with a timer that tries to reconnect every x seconds.

image

It's only after refreshing the web page that the user gets redirected to the page that informs about what happened:

image

Describe the solution you'd like

VS Code should able to detect that the workspace has been idled and should prompt the user:

your-dev-env-has-been-stopped

Note that the workspace can be stopped for multiple reason and we should show a different message each time: eclipse-che/che-dashboard#595

Additional Context

This is a follow up of #20599 and the important PRs provided by @dkwon17

Release Notes Text

Title VS Code notification to inform a developer that his workspace has been stopped and why
When a workspace is stopped (voluntary or not) the user is informed with an explanation of the cause (inactivity, run timeout, error, stopped). The user is also prompted to restart the workspace or to go back to the dashboard.

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/editor/vscode Issues related to the Code OSS editor of Che severity/P1 Has a major impact to usage or development of the system. labels Aug 4, 2022
@l0rd l0rd changed the title Handle idling in VS Code Handle idling in VS Code correctly instead of attempting to reconnect in x seconds Aug 4, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Aug 4, 2022

cc @ibuziuk @dkwon17 @azatsarynnyy

@l0rd l0rd mentioned this issue Oct 28, 2022
73 tasks
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Nov 17, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Nov 18, 2022
68 tasks
@azatsarynnyy azatsarynnyy added this to the 7.59 milestone Nov 23, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Dec 6, 2022
82 tasks
@l0rd l0rd modified the milestones: 7.59, 7.60 Jan 5, 2023
@l0rd
Copy link
Contributor Author

l0rd commented Jan 5, 2023

Moving this issue to milestone 7.60.

@azatsarynnyy azatsarynnyy mentioned this issue Jan 10, 2023
60 tasks
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jan 17, 2023
@RomanNikitenko
Copy link
Member

The PR is ready for review: che-incubator/che-code#163

@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 19, 2023
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 26, 2023
@azatsarynnyy
Copy link
Member

From #22287, it seems became relevant again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

No branches or pull requests

5 participants