Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Che-Code to the latest VS Code upstream changes #21984

Closed
azatsarynnyy opened this issue Feb 2, 2023 · 1 comment
Closed

Adapt Che-Code to the latest VS Code upstream changes #21984

azatsarynnyy opened this issue Feb 2, 2023 · 1 comment
Assignees
@RomanNikitenko
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.61

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe

There're changes in VS Code upstream that conflicts with Che-Code build:

#13 358.3 [12:56:12] Error: /checode-compilation/src/vs/workbench/contrib/remote/browser/che/remote.ts(114,35): Property 'show' does not exist on type 'IDialogService'.
#13 358.3 [12:56:12] Error: /checode-compilation/src/vs/workbench/contrib/remote/browser/che/remote.ts(164,33): Property 'show' does not exist on type 'IDialogService'.

For more details, see the output of the auto-rebase job.

Describe the solution you'd like

Adaptat Che-Code to the upstream changes.
https://github.com/che-incubator/che-code#fixing-the-rebase-insiders-workflow

Describe alternatives you've considered

No response

Additional context

No response
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/vscode Issues related to the Code OSS editor of Che labels Feb 2, 2023
@azatsarynnyy
Copy link
Member Author

@RomanNikitenko the upstream changes conflict with the changes from che-incubator/che-code#163.
It requires just a minor refactoring. Could you take a look? To unblock the auto-rebase workflow.

@azatsarynnyy azatsarynnyy mentioned this issue Feb 2, 2023
Closed
32 tasks
@RomanNikitenko RomanNikitenko self-assigned this Feb 3, 2023
@azatsarynnyy azatsarynnyy added this to the 7.61 milestone Feb 3, 2023
@RomanNikitenko RomanNikitenko mentioned this issue Feb 3, 2023
Merged
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.61
Development

No branches or pull requests
2 participants
@azatsarynnyy @RomanNikitenko