Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bootstrap 4 implications #1

Closed
zkamvar opened this issue Oct 28, 2020 · 3 comments
Closed

Consider bootstrap 4 implications #1

zkamvar opened this issue Oct 28, 2020 · 3 comments

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Oct 28, 2020

There is a lot of discussion buzzing about the R community to switching over to bootstrap 4.

Examples:

r-lib/pkgdown#1409
rstudio/rmarkdown#1260
rstudio/rmarkdown#1260 (comment)

It may be worthwhile just to go with bootstrap4 from the get-go and see if we can tool around that.

@zkamvar
Copy link
Contributor Author

zkamvar commented Oct 28, 2020

I knew this would fail, but the first test with swapping out the script sources for bootstrap 4 and jQuery gives this monstrosity:

image of mis-rendered web page with 3 errors, 1 warning, and 85 debug flags

@fmichonneau
Copy link
Contributor

bootstrap 5 is coming out soon, when using it with our own version of the template, we need to look into whether we should skip version 4 altogether.

@zkamvar
Copy link
Contributor Author

zkamvar commented Mar 16, 2021

I think we may want to start with 4 and migrate to 5 once the RMarkdown verse is also there. At the moment, they are still on 4, but are considering 5: rstudio/bslib#82

One of the things I've been eyeing is using {bslib} and a custom RMarkdown template to control the theming. In theory, this should allow people to more easily customize the template for their use.

@zkamvar zkamvar closed this as completed Jan 29, 2022
milanmlft pushed a commit to milanmlft/varnish that referenced this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants