Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 #82

Closed
cpsievert opened this issue Aug 3, 2020 · 5 comments · Fixed by #304
Closed

Bootstrap 5 #82

cpsievert opened this issue Aug 3, 2020 · 5 comments · Fixed by #304
Assignees
@schloerke

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Aug 3, 2020 •
edited
Loading

No description provided.

@cpsievert cpsievert added this to the First CRAN release milestone Aug 3, 2020
@cpsievert
Copy link
Collaborator Author

Keep in mind the changes to icons (I think Bootstrap 5 adds back in some set of icons)

@cpsievert
Copy link
Collaborator Author

https://blog.getbootstrap.com/2020/06/16/bootstrap-5-alpha/
https://blog.getbootstrap.com/2020/06/26/bootstrap-icons-alpha5/

@cpsievert cpsievert removed this from the First CRAN release milestone Oct 29, 2020
@cpsievert
Copy link
Collaborator Author

cpsievert commented Nov 6, 2020 •
edited
Loading

Looks as though we have to update some data attribute names (data-bs-toggle) https://blog.getbootstrap.com/2020/12/07/bootstrap-5-beta-1/

@zkamvar zkamvar mentioned this issue Mar 16, 2021
Closed
@cpsievert
Copy link
Collaborator Author

cpsievert commented Mar 29, 2021 •
edited
Loading

Waiting on an official Bootswatch 5 release

Here's the diff on the variables file. The biggest changes are to the custom form sass vars twbs/bootstrap@v4.6.0...v5.0.0-beta3

@cpsievert cpsievert mentioned this issue Apr 9, 2021
Merged
2 tasks
@cpsievert cpsievert mentioned this issue Jun 3, 2021
Closed
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bootstrap 5 support rstudio/bslib
2 participants
@schloerke @cpsievert