Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap v4? #1260

Closed
schantanu opened this issue Feb 15, 2018 · 14 comments · Fixed by #1706
Closed

Update to Bootstrap v4? #1260

schantanu opened this issue Feb 15, 2018 · 14 comments · Fixed by #1706

Comments

@schantanu
Copy link

What is the road map to implementation of Bootstrap 4, since it has been fully released now.

I have tried replacing the Bootstrap version in "C:\Program Files\R\R~version\library\rmarkdown\rmd\h\bootstrap-3.3.5", but it has never worked in its entirety. Any suggested hacks for now?

@olgamie
Copy link

olgamie commented Feb 28, 2018

+1

@rich-iannone rich-iannone added the question general questions - not an issue label Mar 12, 2018
@rich-iannone
Copy link
Member

@schantanu Thanks for the suggestion implement Bootstrap 4. We'll consider it as we work on future updates to rmarkdown. There has been no testing yet with Bootstrap so we are unable to provide recommendations on workarounds (and it's not advisable to manually replace the Bootstrap JS library).

@yihui
Copy link
Member

yihui commented Apr 12, 2018

This may be a good item for us to discuss in June during our work week. Shiny has the same issue: rstudio/shiny#1604

@rich-iannone
Copy link
Member

@yihui definitely!

@schantanu
Copy link
Author

Pretty, please. 😀

I have lost my sleep with sticky footer and card groups issues in Bootstrap 3.3.

@illsio
Copy link

illsio commented Jan 16, 2019

Still +1

@royfrancis
Copy link
Contributor

Just leaving a comment here.

@jayhesselberth
Copy link

I worked out BS4 migration in pkgdown and some of it may be useful.

r-lib/pkgdown#1111

@krook1024
Copy link

I'm interested in this too.

@yihui yihui reopened this Oct 8, 2019
@michaelquinn32
Copy link

Twitter has deprecated bootstrap 3.
https://github.com/twbs/release

Has there been any discussion on moving the v4?

Thanks!

@yihui
Copy link
Member

yihui commented Oct 14, 2019

Not yet. Sorry. I have reopened this issue for consideration next year, but I guess the actual work would not be trivial. It is even trickier with the fact that we'll also have to migrate to Bootstrap 4 together with the Shiny team.

Thanks for your patience!

@jcheng5
Copy link
Member

jcheng5 commented Oct 30, 2019

FYI, my team and I have been working on this for months. We think we have a way to move everyone relatively painlessly forward to Bootstrap 4 without breaking backward compatibility for existing documents. Stay tuned.

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2021
@cderv
Copy link
Collaborator

cderv commented Jul 20, 2021

For information for anyone still arriving on this old issue thread now locked, bootstrap 4 can now be used with Rmarkdown using the bslib package. This allows to switch to bootstrap 4 and any newer version that the bslib package will support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.