Upgrade to Bootstrap 4 #1688
Closed
Upgrade to Bootstrap 4 #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ootstrap v3 but not in v4 now
… they don't seem to have ever existed in Bootstrap at all
…tyle="min-width: 50px;" on the dropdown menu, since it doesn't seem to be useful
…ropdown-item class to <a>
…uld have the class 'nav-item'
…with actual font specs so the themes can continue to work offline
…he themes() function
…<li class="divider"> now
…, but it is what the official Bootstrap doc uses)
…s light or dark navbar, and the second specifies the background color
cpsievert
reviewed
Nov 6, 2019
| ) | ||
| w <- c(w, setNames(paste(w, 'Italic'), paste0(names(w), 'italic'))) | ||
| w['400italic'] <- 'Italic' | ||
| fonts <- list.files('fonts') |
There was a problem hiding this comment.
Good to know! Thanks for the tip! The fonts folder exists in the current version of rmarkdown. I guess JJ created it initially. I downloaded a few new fonts for this PR.
|
For some reason navbars with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP to close #1260.
TODO: