Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bootstrap 4 #1688

Closed
wants to merge 25 commits into from
Closed

Upgrade to Bootstrap 4 #1688

wants to merge 25 commits into from

Commits on Nov 5, 2019

  1. drop support for IE8

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    f105ab9 View commit details
    Browse the repository at this point in the history

  2. delete unused files

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    d0a3a0e View commit details
    Browse the repository at this point in the history

  3. close #1260: upgrade Bootstrap from v3 to v4

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    80d497e View commit details
    Browse the repository at this point in the history

  4. an R script to download Bootstrap CSS and JS files

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    3d98410 View commit details
    Browse the repository at this point in the history

  5. tweak styles for <pre> and <code>, which were previously defined in B… 

    …ootstrap v3 but not in v4 now
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    03c04e6 View commit details
    Browse the repository at this point in the history

  6. not sure where these .row-fluid and .fluid-row classes came from, but… 

    … they don't seem to have ever existed in Bootstrap at all
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    c60d8f1 View commit details
    Browse the repository at this point in the history

  7. up grid sizes by one level

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    a298162 View commit details
    Browse the repository at this point in the history

  8. .pull-right -> .float-right; .btn-default -> .btn-secondary; remove s… 

    …tyle="min-width: 50px;" on the dropdown menu, since it doesn't seem to be useful
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    8fea599 View commit details
    Browse the repository at this point in the history

  9. use <a> directly in the dropdown menu, instead of <li><a>; add the .d… 

    …ropdown-item class to <a>
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    eead1ea View commit details
    Browse the repository at this point in the history

  10. the separator's class should be .dropdown-divider instead of .divider… 

    … now
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    7ffb64c View commit details
    Browse the repository at this point in the history

  11. class name 'in' -> 'show'

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    8a7df59 View commit details
    Browse the repository at this point in the history

  12. .btn-default -> .btn-secondary; .btn-xs -> .btn-sm; .pull-right -> .f… 

    …loat-right
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    65178ca View commit details
    Browse the repository at this point in the history

  13. for tabset titles, <a> should have the class 'nav-link', and <li> sho… 

    …uld have the class 'nav-item'
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    2856fee View commit details
    Browse the repository at this point in the history

  14. the 'active' class should be added to <a> instead of <li>

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    0632f2d View commit details
    Browse the repository at this point in the history

  15. rename themes paper to materia and readable to litera

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    351c855 View commit details
    Browse the repository at this point in the history

  16. download all themes from bootswatch.com, and replace the CSS @import … 

    …with actual font specs so the themes can continue to work offline
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    bab60bc View commit details
    Browse the repository at this point in the history

  17. download themes from the bootswatch API instead of parsing its homepa… 

    …ge's HTML
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    e14a343 View commit details
    Browse the repository at this point in the history

  18. dynamically list the available themes instead of hardcoding them in t… 

    …he themes() function
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    275c5b2 View commit details
    Browse the repository at this point in the history

  19. navbar-default has been renamed to navbar-light; navbar-inverse is na… 

    …vbar-dark now
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    0737508 View commit details
    Browse the repository at this point in the history

  20. cosmetic

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    77b933b View commit details
    Browse the repository at this point in the history

  21. the menu divider should be <div class="dropdown-divider"> instead of … 

    …<li class="divider"> now
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    a513aa3 View commit details
    Browse the repository at this point in the history

  22. use <h6> instead of <li> for dropdown headers (not strictly necessary… 

    …, but it is what the official Bootstrap doc uses)
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    23eb382 View commit details
    Browse the repository at this point in the history

  23. update the link to the doc of navbar

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    eed341e View commit details
    Browse the repository at this point in the history

  24. make the navbar type a vector of length 2: the first element specifie… 

    …s light or dark navbar, and the second specifies the background color
    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    2eda617 View commit details
    Browse the repository at this point in the history

  25. generate navbar menus for Bootstrap 4

    @yihui
    yihui committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    57e3ae8 View commit details
    Browse the repository at this point in the history