Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bootstrap 4 #1409

Closed
hadley opened this issue Sep 17, 2020 · 6 comments · Fixed by #1536
Closed

Switch to bootstrap 4 #1409

hadley opened this issue Sep 17, 2020 · 6 comments · Fixed by #1536
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues

Comments

@hadley
Copy link
Member

hadley commented Sep 17, 2020

  • Needed for greater consistency with future releases of shiny, rmarkdown, bookdown etc.
  • Probably needs to be opt-in (or definitely needs to be opt-out)
  • Use bootstrap lib
  • Provide a few customisation parameters (e.g. key colours + font)
@strazto

This comment has been minimized.

@hadley

This comment has been minimized.

@hadley
Copy link
Member Author

hadley commented Nov 3, 2020

Start from template in bookdown::bs4_book()

@hadley hadley added the front end 🌷 General HTML, CSS, and JS issues label Nov 3, 2020
@hadley hadley added the feature a feature request or enhancement label Nov 3, 2020
@jeroen
Copy link
Member

jeroen commented Dec 21, 2020

Also note bootstrap 5 is getting close to a release: http://getbootstrap.com/ . I think this is a relatively small updated from v4, no major changes in the grid layout. https://getbootstrap.com/docs/5.0/migration/

@hadley
Copy link
Member Author

hadley commented Dec 21, 2020

I skimmed a few articles about differences between v4 and v5, and I think this is the best summary: https://designmodo.com/bootstrap-5/

@amirmasoudabdol
Copy link
Contributor

I would be interested in looking into this. I started my project by adapting bootstrap 4, and considered 5 at some point too, but decided to wait for pkgdown and see how you guys are going to more forward.

In terms of compatibility, bootstrap 4 is very much compatible with 3, the only real issue is the navigation bar which needs to be rewritten. Other than that, in my prototypes, I haven't noticed anything else being broken. I think the jump from 3 to 5 is going to be more challenging, but not terribly difficult.

I might start playing around with bootstrap 5 a bit more, as I'm somewhat warmed up! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants