Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DataTable): size prop audit #10999

Merged
merged 10 commits into from
Mar 18, 2022
Merged

chore(DataTable): size prop audit #10999

merged 10 commits into from
Mar 18, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Mar 16, 2022 •
edited
Loading

REF #10295

  • Changed the storybook config in main.js to include subfolders in the next folder so that the Dynamic and Expansion stories could be found.
  • Added the old v10 DataTable stories to the block-list in storybook config.
  • Added FeatureFlag for size prop to only accept xs,sm, md, lg, and xl
  • Added FeatureFlag for lg as a default for the size prop.
  • Added Controls functionality to Storybook.
  • Removed the "Small" story from the DataTable-Batch-Actions story in favor of adding the size controls for the "Default" story.
  • Removed the "Small" story from the DataTable-Toolbar story in favor of adding the size controls for the "Default" story.
  • Removed "Xl", "Sm", "Xs" stories and renamed "DefaultLg" -> "Default" in favor of adding size controls to the now "Default" Basic story.
  • Removed Zebra story from the DefaultLg (now Default) Basic story in favor of Storybook Controls.
  • Removed the redundant size-related stories in the Expansion story in favor of adding the size controls for the "Default" story.
  • Removed old compact, tall, and short styles from @carbon/styles

Testing

  • Ensure that the size controls for all DataTable stories are working as expected.

@sstrubberg sstrubberg requested a review from a team as a code owner March 16, 2022 15:02
@sstrubberg sstrubberg changed the title chore(DataTable): size prop audit first draft chore(DataTable): size prop audit Mar 16, 2022
@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✅ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b4d6640

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6234dd508b714900083eb1a1

😎 Browse the preview: https://deploy-preview-10999--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b4d6640

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6234dd50862cb5000897a4dd

😎 Browse the preview: https://deploy-preview-10999--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 16, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fbe868e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6231ff91fdd9390009bdb948

😎 Browse the preview: https://deploy-preview-10999--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b4d6640

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6234dd5042bbf40008f19a0e

😎 Browse the preview: https://deploy-preview-10999--carbon-components-react.netlify.app

@sstrubberg sstrubberg marked this pull request as draft March 17, 2022 15:06
@sstrubberg sstrubberg marked this pull request as ready for review March 17, 2022 20:41
tay1orjones
tay1orjones approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the deprecated styles, too!

@sstrubberg sstrubberg enabled auto-merge (squash) March 18, 2022 18:44
@sstrubberg sstrubberg merged commit 2ecfa37 into carbon-design-system:main Mar 18, 2022
tay1orjones pushed a commit to tay1orjones/carbon that referenced this pull request Mar 23, 2022
@sstrubberg @tay1orjones
chore(DataTable): size prop audit (carbon-design-system#10999)
34dd2ef 
* chore(DataTable): size prop audit first draft

* chore(DataTable): removed zombies

* chore(DataTable): removed v10 styles

* chore(DataTable): excluded v10 stories

* chore(DataTable): removed sm story from Toolbar

* chore(DataTable): included more dynamic and expansion stories
kodiakhq bot added a commit that referenced this pull request Mar 23, 2022
@tay1orjones @joshblack
@kodiakhq @dakahn @renovate @renovate-bot @sstrubberg
git cherry-pick applicable v10 commits from main (#11039)
ff0571a 
* refactor(project): update AC config and add in AVT tests (#10956)

* test(react): add AVT to breadcrumb

* feat(jest-config): update accessibility-checker config

* test(react): add accessibility-checker tests to ContentSwitcher

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(Combobox): compose onStateChange event handlers (#10968)

* fix(Combobox): compose onStateChange event handlers

* fix(Combobox): remove unnecessary short circuiting

* fix(Combobox): get the optional chaining operator syntax right

* fix(Combobox): add conditional check to downshiftProps object as well

* chore(Carbon): update public api snapshot

* fix(deps): update dependency @carbon/telemetry to v0.1.0 (#10982)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* chore(DataTable): size prop audit (#10999)

* chore(DataTable): size prop audit first draft

* chore(DataTable): removed zombies

* chore(DataTable): removed v10 styles

* chore(DataTable): excluded v10 stories

* chore(DataTable): removed sm story from Toolbar

* chore(DataTable): included more dynamic and expansion stories

* refactor(react): update components to usePrefix or PrefixContent (#11015)

* refactor(react): update components to usePrefix or PrefixContent

* refactor(react): update components to usePrefix (2)

* fix(React): update to new prefix method

* refactor(react): update components to usePrefix (3)

* refactor(react): update components to usePrefix (4)

* chore(react): revert useNormalizedProps as it is used in classes

* chore(react): update tests and incorrect import paths

* test(react): update tests based on changes

* refactor(react): update TabContent usePrefix usage

Co-authored-by: D.A. Kahn <[email protected]>

* 10957 fix datepicker unknown prop warning (#10959)

* fix(Datepicker): add onOpen to destructured props

* fix(Datepicker): remove render call for onOpen

* fix(react): update data-table based on audit (#10966)

* chore: check-in work

* fix(styles): update search bar with data table

* docs(data-table): update batch actions > small story

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* test: update snap

* chore(project): update action to no longer use v10 branch ref

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: DAK <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Scott Strubberg <[email protected]>
Co-authored-by: D.A. Kahn <[email protected]>
This was referenced May 23, 2022
Closed
Closed
Closed
Closed
@joshblack joshblack mentioned this pull request May 23, 2022
Closed
7 tasks
This was referenced May 23, 2022
Closed
Closed
Closed
Closed
Closed
@tay1orjones tay1orjones mentioned this pull request Jun 13, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstrubberg @tay1orjones @dakahn