Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Button.stories.js to include a playground story and interactive controls #11463

Closed
3 of 7 tasks
Tracked by #10751
joshblack opened this issue May 23, 2022 · 0 comments · Fixed by #11523
Closed
3 of 7 tasks
Tracked by #10751

Update Button.stories.js to include a playground story and interactive controls #11463

joshblack opened this issue May 23, 2022 · 0 comments · Fixed by #11523
Assignees
@dakahn
Labels
type: docs 📖

Comments

@joshblack
Copy link
Contributor

joshblack commented May 23, 2022 •
edited by dakahn
Loading

Checklist

  • Move .stories.js file out of next folder, or create .stories.js file and copy contents of *-story.js file over.
  • Remove deprecated knobs package and usage.
  • Ensure there is a playground story
  • Add argTypes to playground story
  • bind() it as a template as described in the storybook docs
  • Pass ...args to playground story, spread them on the applicable component(s)
  • Remove deprecated props from being visible in controls of storybook

Note: if the story has sub-components, document and share with @sstrubberg

Links & Resources
@joshblack joshblack mentioned this issue May 23, 2022
Closed
91 tasks
@joshblack joshblack changed the title components/Button/next/Button.stories.js Update Button.stories.js to include a playground story and interactive controls May 23, 2022
@dakahn dakahn self-assigned this May 23, 2022
@dakahn dakahn mentioned this issue Jun 1, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #11523 Jun 3, 2022
kennylam pushed a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@ariellalgilmore
chore(release): 2.2.0 merge fixes (carbon-design-system#11463)
0407feb 
### Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

### Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakahn dakahn

Labels
type: docs 📖
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(Button): remove v10 stories and update swith v11 dakahn/carbon
2 participants
@joshblack @dakahn