refactor(project): update AC config and add in AVT tests #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 445a136 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/623379b157fc90000979a64a 😎 Browse the preview: https://deploy-preview-10956--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 445a136 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/623379b1c6740c0009aef372 😎 Browse the preview: https://deploy-preview-10956--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 445a136 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/623379b19ff3d800088688c4 😎 Browse the preview: https://deploy-preview-10956--carbon-components-react.netlify.app |
abbeyhrt
approved these changes
Mar 11, 2022
dakahn
approved these changes
Mar 15, 2022
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Mar 23, 2022
…gn-system#10956) * test(react): add AVT to breadcrumb * feat(jest-config): update accessibility-checker config * test(react): add accessibility-checker tests to ContentSwitcher Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot
added a commit
that referenced
this pull request
Mar 23, 2022
* refactor(project): update AC config and add in AVT tests (#10956) * test(react): add AVT to breadcrumb * feat(jest-config): update accessibility-checker config * test(react): add accessibility-checker tests to ContentSwitcher Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(Combobox): compose onStateChange event handlers (#10968) * fix(Combobox): compose onStateChange event handlers * fix(Combobox): remove unnecessary short circuiting * fix(Combobox): get the optional chaining operator syntax right * fix(Combobox): add conditional check to downshiftProps object as well * chore(Carbon): update public api snapshot * fix(deps): update dependency @carbon/telemetry to v0.1.0 (#10982) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(DataTable): size prop audit (#10999) * chore(DataTable): size prop audit first draft * chore(DataTable): removed zombies * chore(DataTable): removed v10 styles * chore(DataTable): excluded v10 stories * chore(DataTable): removed sm story from Toolbar * chore(DataTable): included more dynamic and expansion stories * refactor(react): update components to usePrefix or PrefixContent (#11015) * refactor(react): update components to usePrefix or PrefixContent * refactor(react): update components to usePrefix (2) * fix(React): update to new prefix method * refactor(react): update components to usePrefix (3) * refactor(react): update components to usePrefix (4) * chore(react): revert useNormalizedProps as it is used in classes * chore(react): update tests and incorrect import paths * test(react): update tests based on changes * refactor(react): update TabContent usePrefix usage Co-authored-by: D.A. Kahn <[email protected]> * 10957 fix datepicker unknown prop warning (#10959) * fix(Datepicker): add onOpen to destructured props * fix(Datepicker): remove render call for onOpen * fix(react): update data-table based on audit (#10966) * chore: check-in work * fix(styles): update search bar with data table * docs(data-table): update batch actions > small story Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * test: update snap * chore(project): update action to no longer use v10 branch ref Co-authored-by: Josh Black <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: DAK <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Scott Strubberg <[email protected]> Co-authored-by: D.A. Kahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #9475
This PR updates our AC config to use a custom ruleset and adds in some example tests in different component test files.
Changelog
New
achecker.jsconfig for ACChanged
toHaveNoACViolationsto use custom rulesetRemoved