-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react): update components to usePrefix or PrefixContent #11015
refactor(react): update components to usePrefix or PrefixContent #11015
Conversation
✅ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 55d4aeb 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6234e71f067a160008293dfb 😎 Browse the preview: https://deploy-preview-11015--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a322df0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6233a26715a1bc000810337a 😎 Browse the preview: https://deploy-preview-11015--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a322df0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6233a267a3842b00084765ef 😎 Browse the preview: https://deploy-preview-11015--carbon-components-react.netlify.app |
✅ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 55d4aeb 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6234e71fa416ac0009be89ae 😎 Browse the preview: https://deploy-preview-11015--carbon-elements.netlify.app |
✅ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 55d4aeb 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6234e71fc2703800083671a5 😎 Browse the preview: https://deploy-preview-11015--carbon-components-react.netlify.app |
…:joshblack/carbon into refactor/update-components-to-use-prefix
got some merge conflicts, but looked good on Firefox/Chromium on Linux 👍🏾 |
…factor/update-components-to-use-prefix
…bon-design-system#11015) * refactor(react): update components to usePrefix or PrefixContent * refactor(react): update components to usePrefix (2) * fix(React): update to new prefix method * refactor(react): update components to usePrefix (3) * refactor(react): update components to usePrefix (4) * chore(react): revert useNormalizedProps as it is used in classes * chore(react): update tests and incorrect import paths * test(react): update tests based on changes * refactor(react): update TabContent usePrefix usage Co-authored-by: D.A. Kahn <[email protected]>
* refactor(project): update AC config and add in AVT tests (#10956) * test(react): add AVT to breadcrumb * feat(jest-config): update accessibility-checker config * test(react): add accessibility-checker tests to ContentSwitcher Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(Combobox): compose onStateChange event handlers (#10968) * fix(Combobox): compose onStateChange event handlers * fix(Combobox): remove unnecessary short circuiting * fix(Combobox): get the optional chaining operator syntax right * fix(Combobox): add conditional check to downshiftProps object as well * chore(Carbon): update public api snapshot * fix(deps): update dependency @carbon/telemetry to v0.1.0 (#10982) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(DataTable): size prop audit (#10999) * chore(DataTable): size prop audit first draft * chore(DataTable): removed zombies * chore(DataTable): removed v10 styles * chore(DataTable): excluded v10 stories * chore(DataTable): removed sm story from Toolbar * chore(DataTable): included more dynamic and expansion stories * refactor(react): update components to usePrefix or PrefixContent (#11015) * refactor(react): update components to usePrefix or PrefixContent * refactor(react): update components to usePrefix (2) * fix(React): update to new prefix method * refactor(react): update components to usePrefix (3) * refactor(react): update components to usePrefix (4) * chore(react): revert useNormalizedProps as it is used in classes * chore(react): update tests and incorrect import paths * test(react): update tests based on changes * refactor(react): update TabContent usePrefix usage Co-authored-by: D.A. Kahn <[email protected]> * 10957 fix datepicker unknown prop warning (#10959) * fix(Datepicker): add onOpen to destructured props * fix(Datepicker): remove render call for onOpen * fix(react): update data-table based on audit (#10966) * chore: check-in work * fix(styles): update search bar with data table * docs(data-table): update batch actions > small story Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * test: update snap * chore(project): update action to no longer use v10 branch ref Co-authored-by: Josh Black <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: DAK <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Scott Strubberg <[email protected]> Co-authored-by: D.A. Kahn <[email protected]>
Closes #11014
This PR updates our internal usage of
carbon-components
to only the items that we can't change until v11. It also updates tests as a result of switching tousePrefix
orPrefixContext
which can influence hierarchy with enzyme.Changelog
New
Changed
settings
fromcarbon-components
tousePrefix
orPrefixContext
Removed
Testing / Reviewing